Issue 808003002: Fix compositor integration in ui/compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 808003002: Fix compositor integration in ui/compositor (Closed)

Created:
6 years ago by jamesr

Modified:
6 years ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix compositor integration in ui/compositor Our version of ui/compositor/ did not have https://crrev.com/301512, which recent changes relied on. MojoContextProvider also did not zero-initialize its MojoGLES2Context parameter so if a MojoContextProvider instance was created and then destroyed before being bound it would try to destroy its non-NULL but invalid MojoGLES2Context parameter leading to a crash. R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7bbe37effca2f71221721437f9b21ed41538682a

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -31 lines)			Patch
M	mojo/aura/surface_binding.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/aura/surface_context_factory.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	mojo/aura/surface_context_factory.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	mojo/cc/context_provider_mojo.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/compositor/compositor.h	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	ui/compositor/compositor.cc	View	3 chunks	+7 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

6 years ago (2014-12-17 00:20:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7bbe37effca2f71221721437f9b21ed41538682a (presubmit successful).

Expand Messages | Collapse Messages