util/misc/clock.h - Issue 807973002: win: clock implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: util/misc/clock.h

Issue 807973002: win: clock implementation (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | util/misc/clock.cc » ('j') | util/misc/clock_win.cc » ('J')

OLD	NEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved.	1 // Copyright 2014 The Crashpad Authors. All rights reserved.

2 //	2 //

3 // Licensed under the Apache License, Version 2.0 (the "License");	3 // Licensed under the Apache License, Version 2.0 (the "License");

4 // you may not use this file except in compliance with the License.	4 // you may not use this file except in compliance with the License.

5 // You may obtain a copy of the License at	5 // You may obtain a copy of the License at

6 //	6 //

7 // http://www.apache.org/licenses/LICENSE-2.0	7 // http://www.apache.org/licenses/LICENSE-2.0

8 //	8 //

9 // Unless required by applicable law or agreed to in writing, software	9 // Unless required by applicable law or agreed to in writing, software

10 // distributed under the License is distributed on an "AS IS" BASIS,	10 // distributed under the License is distributed on an "AS IS" BASIS,

(...skipping 20 matching lines...) Expand all Loading...
31 //!	31 //!

32 //! \return The value of the system’s monotonic clock, in nanoseconds.	32 //! \return The value of the system’s monotonic clock, in nanoseconds.

33 uint64_t ClockMonotonicNanoseconds();	33 uint64_t ClockMonotonicNanoseconds();

34	34

35 //! \brief Sleeps for the specified duration.	35 //! \brief Sleeps for the specified duration.

36 //!	36 //!

37 //! \param[in] nanoseconds The number of nanoseconds to sleep. The actual sleep	37 //! \param[in] nanoseconds The number of nanoseconds to sleep. The actual sleep

38 //! may be slightly longer due to latencies and timer resolution.	38 //! may be slightly longer due to latencies and timer resolution.

39 //!	39 //!

40 //! This function is resilient against the underlying `nanosleep()` system call	40 //! This function is resilient against the underlying `nanosleep()` system call

41 //! being interrupted by a signal.	41 //! being interrupted by a signal. On Windows, timeBeginPeriod is not adjusted.
	Mark Mentovai 2014/12/16 23:06:53 nanosleep is a POSIXism, so that sentence should s nanosleep is a POSIXism, so that sentence should say so. `timeBeginPeriod()`? Also, I didn’t know what that did without looking it up, and its name doesn’t make it obvious, so maybe tack on something like “to set the timer resolution,” if that’s even correct. scottmg 2014/12/17 01:01:28 Done. Show quoted text On 2014/12/16 23:06:53, Mark Mentovai wrote: > nanosleep is a POSIXism, so that sentence should say so. > > `timeBeginPeriod()`? Also, I didn’t know what that did without looking it up, > and its name doesn’t make it obvious, so maybe tack on something like “to set > the timer resolution,” if that’s even correct. Done.
42 void SleepNanoseconds(uint64_t nanoseconds);	42 void SleepNanoseconds(uint64_t nanoseconds);

43	43

44 } // namespace crashpad	44 } // namespace crashpad

45	45

46 #endif // CRASHPAD_UTIL_MISC_CLOCK_H_	46 #endif // CRASHPAD_UTIL_MISC_CLOCK_H_

OLD	NEW