Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 807933003: Don't sort tree scopes in StyleEngine. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't sort tree scopes in StyleEngine. Sky doesn't have tree boundary crossing rules so we don't need to sort the list of tree scopes in the StyleEngine. This was needed to make tree boundary crossing rules apply in the right order. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/671592b24bbe672b2f2ce58f190fdfebf411e239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -31 lines) Patch
M sky/engine/core/dom/StyleEngine.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 2 chunks +1 line, -28 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
6 years ago (2014-12-16 23:09:33 UTC) #2
esprehn
6 years ago (2014-12-16 23:11:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
671592b24bbe672b2f2ce58f190fdfebf411e239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698