Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 807893002: ES6: Update unscopables to match spec (Closed)

Created:
6 years ago by arv (Not doing code reviews)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ES6: Update unscopables to match spec The spec ended up using Get(unscopables, propertyName) and comparing the result to undefined instead of using Has. BUG=v8:3632 LOG=Y R=adamk, dslomov@chromium.org Committed: https://crrev.com/2639bfe9930b179727d58ae37e10b82262be1154 Cr-Commit-Position: refs/heads/master@{#25854}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -12 lines) Patch
M src/contexts.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M test/mjsunit/es6/unscopables.js View 1 7 chunks +63 lines, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-with-unscopables.js View 1 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
arv (Not doing code reviews)
cleanup
6 years ago (2014-12-16 17:50:30 UTC) #1
arv (Not doing code reviews)
PTAL There is a minor compatibility risk here. If someone used {key: undefined} in their ...
6 years ago (2014-12-16 17:52:52 UTC) #2
Dmitry Lomov (no reviews)
lgtm
6 years ago (2014-12-16 18:31:09 UTC) #3
adamk
lgtm
6 years ago (2014-12-16 18:32:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807893002/20001
6 years ago (2014-12-16 19:40:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-16 20:07:36 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-17 10:14:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2639bfe9930b179727d58ae37e10b82262be1154
Cr-Commit-Position: refs/heads/master@{#25854}

Powered by Google App Engine
This is Rietveld 408576698