Use GLHelper support to validate format before processing texture.

Use GLHelper support to validate format before processing texture.

IsReadbackConfig can be used to query whether 
readback of particular format texture is supported.


BUG=415682

[sivag, 2014-12-24 16:12:51]

siva.gunturi@samsung.com changed reviewers:
+ ccameron@chromium.org, danakj@chromium.org

[sivag, 2014-12-24 16:14:44]

siva.gunturi@samsung.com changed reviewers:
+ piman@chromium.org

[sivag, 2014-12-26 06:07:05]

ptal..

[danakj, 2014-12-26 20:09:09]

danakj@chromium.org changed reviewers:
+ sievers@chromium.org

[sivag, 2015-01-06 10:45:41]

siva.gunturi@samsung.com changed reviewers:
- ccameron@chromium.org

[sivag, 2015-01-06 10:46:56]

@piman, dana ptal..

[danakj, 2015-01-06 16:16:20]

https://codereview.chromium.org/807853003/diff/20001/content/browser/composit...
File content/browser/compositor/delegated_frame_host.cc (right):

https://codereview.chromium.org/807853003/diff/20001/content/browser/composit...
content/browser/compositor/delegated_frame_host.cc:614: //// static
just one // is enough

https://codereview.chromium.org/807853003/diff/20001/content/browser/composit...
content/browser/compositor/delegated_frame_host.cc:633: if
(!IsReadbackConfigSupported(color_type))
This makes us GetGLHelper() twice, IWBN to only call that function once.

Also previously if GetGLHelper() gave null, we would READBACK_FAILED. Now we
READBACK_FORMAT_NOT_SUPPORTED, which maybe is not right?

[piman, 2015-01-06 17:50:27]

LGTM after Dana's comments are addressed.

[sivag, 2015-01-07 09:33:32]

@dana, ptal..

https://codereview.chromium.org/807853003/diff/20001/content/browser/composit...
File content/browser/compositor/delegated_frame_host.cc (right):

https://codereview.chromium.org/807853003/diff/20001/content/browser/composit...
content/browser/compositor/delegated_frame_host.cc:614: //// static
On 2015/01/06 16:16:19, danakj wrote:
> just one // is enough

Done.

https://codereview.chromium.org/807853003/diff/20001/content/browser/composit...
content/browser/compositor/delegated_frame_host.cc:633: if
(!IsReadbackConfigSupported(color_type))
On 2015/01/06 16:16:19, danakj wrote:
> This makes us GetGLHelper() twice, IWBN to only call that function once.
> 
> Also previously if GetGLHelper() gave null, we would READBACK_FAILED. Now we
> READBACK_FORMAT_NOT_SUPPORTED, which maybe is not right?

Done.

[danakj, 2015-01-08 05:56:31]

Thanks. One more comment

https://codereview.chromium.org/807853003/diff/40001/content/browser/composit...
File content/browser/compositor/delegated_frame_host.cc (right):

https://codereview.chromium.org/807853003/diff/40001/content/browser/composit...
content/browser/compositor/delegated_frame_host.cc:620:
DCHECK(result->HasTexture());
Nit: blank line between dcheck and code

https://codereview.chromium.org/807853003/diff/40001/content/browser/composit...
content/browser/compositor/delegated_frame_host.cc:632:
base::ScopedClosureRunner scoped_callback_runner(
Maybe move this to the top of the function, and just reset the scoped runner
when calling with format error?

[sivag, 2015-01-08 11:03:32]

dana, ptal..

https://codereview.chromium.org/807853003/diff/40001/content/browser/composit...
File content/browser/compositor/delegated_frame_host.cc (right):

https://codereview.chromium.org/807853003/diff/40001/content/browser/composit...
content/browser/compositor/delegated_frame_host.cc:620:
DCHECK(result->HasTexture());
On 2015/01/08 05:56:31, danakj wrote:
> Nit: blank line between dcheck and code

Done.

https://codereview.chromium.org/807853003/diff/40001/content/browser/composit...
content/browser/compositor/delegated_frame_host.cc:632:
base::ScopedClosureRunner scoped_callback_runner(
On 2015/01/08 05:56:31, danakj wrote:
> Maybe move this to the top of the function, and just reset the scoped runner
> when calling with format error?

Done.

[danakj, 2015-01-08 17:31:28]

lgtm

[sivag, 2015-01-08 18:17:18]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2015-01-08 18:19:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807853003/60001

[commit-bot: I haz the power, 2015-01-08 19:19:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 19:19:16]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sivag, 2015-01-09 08:55:32]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2015-01-09 08:56:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807853003/60001

[commit-bot: I haz the power, 2015-01-09 09:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-09 09:54:23]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sivag, 2015-01-15 14:53:23]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2015-01-15 14:53:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807853003/60001

[commit-bot: I haz the power, 2015-01-15 14:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 14:54:19]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sivag, 2015-02-10 12:34:45]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2015-02-10 12:35:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807853003/60001

[commit-bot: I haz the power, 2015-02-10 14:17:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-10 14:17:56]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sivag, 2015-04-01 10:59:49]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2015-04-01 11:00:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807853003/60001

[sivag, 2015-11-25 06:24:45]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 06:25:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807853003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/807853003/120001

[commit-bot: I haz the power, 2015-11-25 07:51:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 07:51:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sivag, 2016-06-01 15:04:25]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 15:04:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807853003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/807853003/120001

[commit-bot: I haz the power, 2016-06-01 15:07:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 15:07:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sivag, 2016-06-01 15:26:17]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 15:26:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807853003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/807853003/140001

[commit-bot: I haz the power, 2016-06-01 16:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 16:34:01]

Dry run: This issue passed the CQ dry run.

[sivag, 2016-06-02 06:50:41]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 06:51:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807853003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/807853003/180001

[sivag, 2016-06-02 07:01:58]

The CQ bit was unchecked by siva.gunturi@samsung.com

[sivag, 2016-06-02 09:07:29]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 09:07:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807853003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/807853003/200001

[commit-bot: I haz the power, 2016-06-02 09:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 09:42:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)