Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/stdio_linux.cc

Issue 807833002: Revert "Make stdout/stderr async" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review commetns Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/stdio.cc ('k') | runtime/bin/stdio_macos.cc » ('j') | sdk/lib/_internal/compiler/js_lib/io_patch.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/stdio_linux.cc
diff --git a/runtime/bin/stdio_linux.cc b/runtime/bin/stdio_linux.cc
index dee8c389e3669ece4c9c9672209ae31e00aaa60c..c01a77180673b4878ef8f1a7dee7fe60322197bb 100644
--- a/runtime/bin/stdio_linux.cc
+++ b/runtime/bin/stdio_linux.cc
@@ -65,9 +65,9 @@ void Stdin::SetLineMode(bool enabled) {
}
-bool Stdout::GetTerminalSize(int size[2]) {
+bool Stdout::GetTerminalSize(intptr_t fd, int size[2]) {
struct winsize w;
- if (NO_RETRY_EXPECTED(ioctl(STDOUT_FILENO, TIOCGWINSZ, &w)) == 0 &&
+ if (NO_RETRY_EXPECTED(ioctl(fd, TIOCGWINSZ, &w)) == 0 &&
(w.ws_col != 0 || w.ws_row != 0)) {
size[0] = w.ws_col;
size[1] = w.ws_row;
@@ -80,4 +80,3 @@ bool Stdout::GetTerminalSize(int size[2]) {
} // namespace dart
#endif // defined(TARGET_OS_LINUX)
-
« no previous file with comments | « runtime/bin/stdio.cc ('k') | runtime/bin/stdio_macos.cc » ('j') | sdk/lib/_internal/compiler/js_lib/io_patch.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698