pkg/analysis_server/lib/src/server/stdio_server.dart - Issue 807833002: Revert "Make stdout/stderr async"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/server/stdio_server.dart

Issue 807833002: Revert "Make stdout/stderr async" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review commetns Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/server/stdio_server.dart

diff --git a/pkg/analysis_server/lib/src/server/stdio_server.dart b/pkg/analysis_server/lib/src/server/stdio_server.dart

index d28dbde86db482023516f95d2bbedc48fba5560a..6eab23018ffa870447a8968cf57f28a6dc55970d 100644

--- a/pkg/analysis_server/lib/src/server/stdio_server.dart

+++ b/pkg/analysis_server/lib/src/server/stdio_server.dart

@@ -36,7 +36,7 @@ class StdioAnalysisServer {

Future serveStdio() {

ByteStreamServerChannel serverChannel = new ByteStreamServerChannel(

stdin,

- stdout,

+ stdout.nonBlocking,

socketServer.instrumentationService);

socketServer.createAnalysisServer(serverChannel);

return serverChannel.closed;

« no previous file with comments | « no previous file | runtime/bin/io_natives.cc » ('j') | sdk/lib/_internal/compiler/js_lib/io_patch.dart » ('J')