Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: runtime/bin/stdio.cc

Issue 807833002: Revert "Make stdout/stderr async" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review commetns Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/builtin.h" 5 #include "bin/builtin.h"
6 #include "bin/dartutils.h" 6 #include "bin/dartutils.h"
7 #include "bin/utils.h" 7 #include "bin/utils.h"
8 #include "bin/stdio.h" 8 #include "bin/stdio.h"
9 9
10 #include "platform/globals.h" 10 #include "platform/globals.h"
(...skipping 27 matching lines...) Expand all
38 } 38 }
39 39
40 40
41 void FUNCTION_NAME(Stdin_SetLineMode)(Dart_NativeArguments args) { 41 void FUNCTION_NAME(Stdin_SetLineMode)(Dart_NativeArguments args) {
42 bool enabled = DartUtils::GetBooleanValue(Dart_GetNativeArgument(args, 0)); 42 bool enabled = DartUtils::GetBooleanValue(Dart_GetNativeArgument(args, 0));
43 Stdin::SetLineMode(enabled); 43 Stdin::SetLineMode(enabled);
44 } 44 }
45 45
46 46
47 void FUNCTION_NAME(Stdout_GetTerminalSize)(Dart_NativeArguments args) { 47 void FUNCTION_NAME(Stdout_GetTerminalSize)(Dart_NativeArguments args) {
48 intptr_t fd = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 0));
49 if (fd != 1 && fd != 2) {
50 Dart_PropagateError(Dart_NewApiError("Terminal fd must be 1 or 2"));
51 }
52
48 int size[2]; 53 int size[2];
49 if (Stdout::GetTerminalSize(size)) { 54 if (Stdout::GetTerminalSize(fd, size)) {
50 Dart_Handle list = Dart_NewList(2); 55 Dart_Handle list = Dart_NewList(2);
51 Dart_ListSetAt(list, 0, Dart_NewInteger(size[0])); 56 Dart_ListSetAt(list, 0, Dart_NewInteger(size[0]));
52 Dart_ListSetAt(list, 1, Dart_NewInteger(size[1])); 57 Dart_ListSetAt(list, 1, Dart_NewInteger(size[1]));
53 Dart_SetReturnValue(args, list); 58 Dart_SetReturnValue(args, list);
54 } else { 59 } else {
55 Dart_SetReturnValue(args, DartUtils::NewDartOSError()); 60 Dart_SetReturnValue(args, DartUtils::NewDartOSError());
56 } 61 }
57 } 62 }
58 63
59 } // namespace bin 64 } // namespace bin
60 } // namespace dart 65 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698