DescriptionRevert of Reland https://codereview.chromium.org/292153006 with minor changes. (patchset #8 id:140001 of https://codereview.chromium.org/728233003/)
Reason for revert:
Reverting because of NaCl tests breakage (http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/5396/steps/browser_tests/logs/NetAddressPrivate)
This probably happened because __asan_default_options got stripped.
Original issue's description:
> Reland https://codereview.chromium.org/292153006 (Enable mac_strip_release under ASan on OSX. Remove the .saves files) with minor changes.
>
> Unce upon a time the ASan runtime library used to be statically linked into
> the executables on OSX.
> Because that library provided a number of API functions needed by the shared
> libraries, we had custom ASan-specific .saves files that told the `strip`
> utility to preserve those functions when stripping the executables.
>
> Then ASan switched to using dynamic runtime library, which instantly broke the
> stripping step, because the executables weren't necessarily referencing all the
> ASan API functions (issue 242503).
> As a result, stripping has been disabled, and we haven't had .dSYM debug info
> for ASan builds for more than a year now (issue 148383).
>
> This CL makes the buildsystem strip only the debug info from the ASan binaries.
> As a result, the .saves files aren't necessary anymore.
> This CL deletes them and turns mac_strip_release on for ASan
> builds.
>
> BUG=148383, 242503, 170739, 166857
> TBR=mark@chromium.org
>
> Committed: https://crrev.com/1c2a4917f604903f092bb00afefbd0d5223bd2a8
> Cr-Commit-Position: refs/heads/master@{#308976}
TBR=mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148383, 242503, 170739, 166857
Committed: https://crrev.com/791bbbfe20de1ead63c723e12ddcda912074934b
Cr-Commit-Position: refs/heads/master@{#308981}
Patch Set 1 #
Created: 6 years ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|