Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 807813005: Revert of Reland https://codereview.chromium.org/292153006 with minor changes. (Closed)

Created:
6 years ago by Alexander Potapenko
Modified:
6 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, inferno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland https://codereview.chromium.org/292153006 with minor changes. (patchset #8 id:140001 of https://codereview.chromium.org/728233003/) Reason for revert: Reverting because of NaCl tests breakage (http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/5396/steps/browser_tests/logs/NetAddressPrivate) This probably happened because __asan_default_options got stripped. Original issue's description: > Reland https://codereview.chromium.org/292153006 (Enable mac_strip_release under ASan on OSX. Remove the .saves files) with minor changes. > > Unce upon a time the ASan runtime library used to be statically linked into > the executables on OSX. > Because that library provided a number of API functions needed by the shared > libraries, we had custom ASan-specific .saves files that told the `strip` > utility to preserve those functions when stripping the executables. > > Then ASan switched to using dynamic runtime library, which instantly broke the > stripping step, because the executables weren't necessarily referencing all the > ASan API functions (issue 242503). > As a result, stripping has been disabled, and we haven't had .dSYM debug info > for ASan builds for more than a year now (issue 148383). > > This CL makes the buildsystem strip only the debug info from the ASan binaries. > As a result, the .saves files aren't necessary anymore. > This CL deletes them and turns mac_strip_release on for ASan > builds. > > BUG=148383, 242503, 170739, 166857 > TBR=mark@chromium.org > > Committed: https://crrev.com/1c2a4917f604903f092bb00afefbd0d5223bd2a8 > Cr-Commit-Position: refs/heads/master@{#308976} TBR=mark@chromium.org NOTREECHECKS=true NOTRY=true BUG=148383, 242503, 170739, 166857 Committed: https://crrev.com/791bbbfe20de1ead63c723e12ddcda912074934b Cr-Commit-Position: refs/heads/master@{#308981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -1 line) Patch
A build/asan.saves View 1 chunk +23 lines, -0 lines 0 comments Download
M build/common.gypi View 3 chunks +20 lines, -1 line 0 comments Download
A chrome/app/app_asan.saves View 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
Created Revert of Reland https://codereview.chromium.org/292153006 with minor changes.
6 years ago (2014-12-18 10:30:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807813005/1
6 years ago (2014-12-18 10:31:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 10:31:54 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-18 10:32:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/791bbbfe20de1ead63c723e12ddcda912074934b
Cr-Commit-Position: refs/heads/master@{#308981}

Powered by Google App Engine
This is Rietveld 408576698