Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 807773002: Move mojo gypfiles to toplevel mojo (Closed)

Created:
6 years ago by Ken Rockot(use gerrit already)
Modified:
6 years ago
Reviewers:
jamesr
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, timvolodine, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move mojo gypfiles to toplevel mojo These files are owned by chromium now. It would not only be weird to inject them into the rolled mojo directory structure, but doing so would unnecessarily complicate the mojo up-rev procedure. BUG=None TBR=darin@chromium.org Committed: https://crrev.com/829dc9ae81e2ad2f6b890dde15cbe2fc299bc711 Cr-Commit-Position: refs/heads/master@{#308622}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1001 lines, -1619 lines) Patch
M build/all.gyp View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_web_ui_mojo_bindings.gyp View 1 chunk +1 line, -1 line 0 comments Download
M content/content.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M content/content_common.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 5 chunks +11 lines, -11 lines 0 comments Download
M device/battery/battery.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M device/serial/serial.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M device/vibration/vibration.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/extensions.gyp View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 3 chunks +7 lines, -7 lines 0 comments Download
D mojo/edk/mojo_edk.gyp View 1 chunk +0 lines, -144 lines 0 comments Download
D mojo/edk/mojo_edk_system_impl.gypi View 1 chunk +0 lines, -131 lines 0 comments Download
D mojo/edk/mojo_edk_tests.gyp View 1 chunk +0 lines, -279 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/mojo_base.gyp View 5 chunks +11 lines, -11 lines 0 comments Download
A + mojo/mojo_edk.gyp View 8 chunks +45 lines, -45 lines 0 comments Download
A mojo/mojo_edk_system_impl.gypi View 1 chunk +131 lines, -0 lines 0 comments Download
A mojo/mojo_edk_tests.gyp View 1 chunk +279 lines, -0 lines 0 comments Download
M mojo/mojo_geometry_converters.gyp View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_input_events_converters.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/mojo_nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download
A mojo/mojo_public.gyp View 1 chunk +385 lines, -0 lines 0 comments Download
A + mojo/mojo_services_public.gyp View 14 chunks +73 lines, -73 lines 0 comments Download
M mojo/mojo_variables.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/mojom_bindings_generator.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/mojom_bindings_generator_explicit.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/mojom_bindings_generator_variables.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/public/mojo_public.gyp View 1 chunk +0 lines, -385 lines 0 comments Download
D mojo/public/tools/bindings/mojom_bindings_generator.gypi View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/public/tools/bindings/mojom_bindings_generator_explicit.gypi View 1 chunk +0 lines, -80 lines 0 comments Download
D mojo/public/tools/bindings/mojom_bindings_generator_variables.gypi View 1 chunk +0 lines, -67 lines 0 comments Download
D mojo/services/public/mojo_services_public.gyp View 1 chunk +0 lines, -267 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ken Rockot(use gerrit already)
6 years ago (2014-12-16 18:25:47 UTC) #6
jamesr
lgtm (might wanna just TBR=darin for the whole shebang)
6 years ago (2014-12-16 18:34:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807773002/60001
6 years ago (2014-12-16 18:44:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:60001)
6 years ago (2014-12-16 18:49:02 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-16 18:49:47 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/829dc9ae81e2ad2f6b890dde15cbe2fc299bc711
Cr-Commit-Position: refs/heads/master@{#308622}

Powered by Google App Engine
This is Rietveld 408576698