Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 807753002: Add angle_end2end_tests target and isolate. (Closed)

Created:
6 years ago by Ken Russell (switch to Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add angle_end2end_tests target and isolate. It's not feasible to reference ANGLE's test targets directly because Chromium must use base's test launcher and ANGLE may not refer to it. This new target and angle_unittests have been refactored in terms of .gypi files provided by the ANGLE workspace, allowing both workspaces to build these targets, though their main.cpp files differ. BUG=435726 Committed: https://crrev.com/db69c444f63013597dca063a3256ae37c7f539c9 Cr-Commit-Position: refs/heads/master@{#309366}

Patch Set 1 #

Patch Set 2 : Forgot the new isolate. #

Patch Set 3 : Refactored in terms of .gypi files forthcoming in ANGLE. #

Patch Set 4 : Deleted obsolete isolate. #

Patch Set 5 : Deleted obsolete .gypi. #

Patch Set 6 : Rebased. #

Patch Set 7 : Removed accidentally duplicated 'type' in gpu.gyp. #

Patch Set 8 : Removed unneeded and incorrect reference to ShInitialize/Finalize. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -40 lines) Patch
A + chrome/angle_end2end_tests.isolate View 1 2 1 chunk +20 lines, -20 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 1 chunk +15 lines, -0 lines 0 comments Download
A + gpu/angle_end2end_tests_main.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -4 lines 0 comments Download
M gpu/gpu.gyp View 1 2 3 4 5 6 2 chunks +30 lines, -16 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
Ken Russell (switch to Gerrit)
(geofflang or jmadill) and (bajones or zmo): please review. (piman or sievers): OWNERS review please. ...
6 years ago (2014-12-16 01:36:14 UTC) #2
Ken Russell (switch to Gerrit)
(csharp or maruel): OWNERS review of the new isolate please. Thanks.
6 years ago (2014-12-16 01:38:27 UTC) #4
M-A Ruel
lgtm
6 years ago (2014-12-16 01:44:01 UTC) #5
piman
lgtm
6 years ago (2014-12-16 02:37:03 UTC) #6
Geoff Lang
lgtm
6 years ago (2014-12-16 20:18:06 UTC) #7
bajones
lgtm
6 years ago (2014-12-16 22:06:20 UTC) #8
Ken Russell (switch to Gerrit)
No re-review necessary, but any comments welcome. This now depends on https://chromium-review.googlesource.com/236681 . Once that ...
6 years ago (2014-12-19 00:32:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807753002/100001
6 years ago (2014-12-20 00:06:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_rel/builds/1764)
6 years ago (2014-12-20 00:14:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807753002/120001
6 years ago (2014-12-20 01:31:04 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg/builds/44690)
6 years ago (2014-12-20 02:36:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807753002/140001
6 years ago (2014-12-20 22:39:19 UTC) #19
commit-bot: I haz the power
Committed patchset #8 (id:140001)
6 years ago (2014-12-20 23:39:14 UTC) #20
commit-bot: I haz the power
6 years ago (2014-12-20 23:39:50 UTC) #21
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/db69c444f63013597dca063a3256ae37c7f539c9
Cr-Commit-Position: refs/heads/master@{#309366}

Powered by Google App Engine
This is Rietveld 408576698