Split surface id and simplify connecting to surfaces service

examples/surfaces_app/child_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "examples/surfaces_app/child_impl.h"
 
 #include "base/bind.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/delegated_frame_data.h"
 #include "cc/quads/render_pass.h"
@@ skipping 10 matching lines @@
 namespace mojo {
 namespace examples {
 
 using cc::RenderPass;
 using cc::RenderPassId;
 using cc::DrawQuad;
 using cc::SolidColorDrawQuad;
 using cc::DelegatedFrameData;
 using cc::CompositorFrame;
 
-ChildImpl::ChildImpl(ApplicationConnection* surfaces_service_connection)
-    : weak_factory_(this) {
-  surfaces_service_connection->ConnectToService(&surfaces_service_);
-  surfaces_service_->CreateSurfaceConnection(base::Bind(
-      &ChildImpl::SurfaceConnectionCreated, weak_factory_.GetWeakPtr()));
+ChildImpl::ChildImpl(ApplicationConnection* surfaces_service_connection) {
+  surfaces_service_connection->ConnectToService(&surface_);
+  surface_.set_client(this);
+  surface_.WaitForIncomingMethodCall();  // Wait for ID namespace to arrive.
 }
 
 ChildImpl::~ChildImpl() {
   if (surface_)
     surface_->DestroySurface(mojo::SurfaceId::From(id_));
 }
 
-void ChildImpl::ProduceFrame(
-    ColorPtr color,
-    SizePtr size,
-    const mojo::Callback<void(SurfaceIdPtr id)>& callback) {
-  color_ = color.To<SkColor>();
-  size_ = size.To<gfx::Size>();
-  produce_callback_ = callback;
-  if (allocator_)
-    Draw();
-}
-
-void ChildImpl::SurfaceConnectionCreated(SurfacePtr surface,
-                                         uint32_t id_namespace) {
-  surface_ = surface.Pass();
-  surface_.set_client(this);
+void ChildImpl::SetIdNamespace(uint32_t id_namespace) {
   allocator_.reset(new cc::SurfaceIdAllocator(id_namespace));
-  if (!produce_callback_.is_null())
-    Draw();
 }
 
 void ChildImpl::ReturnResources(
     Array<ReturnedResourcePtr> resources) {
   DCHECK(!resources.size());
 }
 
-void ChildImpl::Draw() {
+void ChildImpl::ProduceFrame(
+    ColorPtr color,
+    SizePtr size_ptr,
+    const mojo::Callback<void(SurfaceIdPtr id)>& callback) {
   id_ = allocator_->GenerateId();
-  surface_->CreateSurface(mojo::SurfaceId::From(id_),
-                          mojo::Size::From(size_));
-  gfx::Rect rect(size_);
+  surface_->CreateSurface(mojo::SurfaceId::From(id_));
+  gfx::Size size = size_ptr.To<gfx::Size>();
+  gfx::Rect rect(size);
   RenderPassId id(1, 1);
   scoped_ptr<RenderPass> pass = RenderPass::Create();
   pass->SetNew(id, rect, rect, gfx::Transform());
 
-  CreateAndAppendSimpleSharedQuadState(pass.get(), gfx::Transform(), size_);
+  CreateAndAppendSimpleSharedQuadState(pass.get(), gfx::Transform(), size);
 
   SolidColorDrawQuad* color_quad =
       pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
   bool force_anti_aliasing_off = false;
   color_quad->SetNew(pass->shared_quad_state_list.back(),
                      rect,
                      rect,
-                     color_,
+                     color.To<SkColor>(),
                      force_anti_aliasing_off);
 
   scoped_ptr<DelegatedFrameData> delegated_frame_data(new DelegatedFrameData);
   delegated_frame_data->render_pass_list.push_back(pass.Pass());
 
   scoped_ptr<CompositorFrame> frame(new CompositorFrame);
   frame->delegated_frame_data = delegated_frame_data.Pass();
 
   surface_->SubmitFrame(mojo::SurfaceId::From(id_), mojo::Frame::From(*frame),
                         mojo::Closure());
-  produce_callback_.Run(SurfaceId::From(id_));
+  callback.Run(SurfaceId::From(id_));
 }
 
 }  // namespace examples
 }  // namespace mojo