Cast audio only policy enforcement support.

extensions/browser/api/cast_channel/cast_channel_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/cast_channel/cast_channel_api.h"
 
 #include <limits>
 #include <string>
 
 #include "base/json/json_writer.h"
@@ skipping 12 matching lines @@
 #include "extensions/common/api/cast_channel/logging.pb.h"
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_util.h"
 #include "url/gurl.h"
 
 // Default timeout interval for connection setup.
 // Used if not otherwise specified at ConnectInfo::timeout.
 const int kDefaultConnectTimeoutMillis = 5000;  // 5 seconds.
 
+// Cast device capabilities.
+enum CastDeviceCapability {
+  VIDEO_OUT = (1 << 0),

[mark a. foltz, 2015/01/12 22:01:57]

I don't think the parenthesis are necessary.

[vadimgo, 2015/01/13 00:08:27]

Removed parenthesis.

+  VIDEO_IN = (1 << 1),
+  AUDIO_OUT = (1 << 2),
+  AUDIO_IN = (1 << 3),
+  DEV_MODE = (1 << 4)
+};
+
 namespace extensions {
 
 namespace Close = cast_channel::Close;
 namespace OnError = cast_channel::OnError;
 namespace OnMessage = cast_channel::OnMessage;
 namespace Open = cast_channel::Open;
 namespace Send = cast_channel::Send;
 using cast_channel::CastMessage;
 using cast_channel::CastSocket;
 using cast_channel::ChannelAuthType;
@@ skipping 298 matching lines @@
   if (test_socket.get()) {
     socket = test_socket.release();
   } else {
     socket = new cast_channel::CastSocketImpl(
         extension_->id(), *ip_endpoint_, channel_auth_,
         ExtensionsBrowserClient::Get()->GetNetLog(),
         base::TimeDelta::FromMilliseconds(connect_info_->timeout.get()
                                               ? *connect_info_->timeout
                                               : kDefaultConnectTimeoutMillis),
         api_->GetLogger());
+
+    // If device capabilities are available in the connect information, pass the

[mark a. foltz, 2015/01/12 22:01:56]

Slightly prefer to pass the capabilities in the CastSocket ctor; perhaps you can
pass a default if they are not set in connect_info?

[vadimgo, 2015/01/13 00:08:27]

Changed to pass device capabilities to the socket constructor.

+    // claimed video out capability to the socket for audio only policy
+    // enforcement.
+    if (connect_info_->capabilities.get()) {
+      bool has_video_out =
+          (*connect_info_->capabilities & CastDeviceCapability::VIDEO_OUT) ==
+          CastDeviceCapability::VIDEO_OUT;
+      socket->set_has_video_out(has_video_out);

[mark a. foltz, 2015/01/12 22:01:56]

ISTM we should have an API like

socket->HasCapability(VIDEO_OUT)

(assuming capabilities are set in the ctor as suggested above).

[vadimgo, 2015/01/13 00:08:27]

This code is removed with the new api design.

+    }
   }
   new_channel_id_ = AddSocket(socket);
   scoped_ptr<CastMessageHandler> delegate(new CastMessageHandler(api_, socket));
   api_->GetLogger()->LogNewSocketEvent(*socket);
   socket->Connect(delegate.Pass(),
                   base::Bind(&CastChannelOpenFunction::OnOpen, this));
 }
 
 void CastChannelOpenFunction::OnOpen(cast_channel::ChannelError result) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
@@ skipping 201 matching lines @@
   std::string& signature = params_->signature;
   if (signature.empty() || keys.empty() ||
       !cast_channel::SetTrustedCertificateAuthorities(keys, signature)) {
     SetError("Unable to set authority keys.");
   }
 
   AsyncWorkCompleted();
 }
 
 }  // namespace extensions