Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 807703003: Remove @media rules. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove @media rules. In sky we only support inline styles and <style media>, not @media rules. This removes the Bison support for parsing them which was also removed in Blink in favor of the other media query parser which was added for use on the pre-scanner thread. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/51d85c969c708594760f6b98ef31855653fea4e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -445 lines) Patch
M sky/engine/core/css/MediaList.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M sky/engine/core/css/RuleSet.h View 3 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/css/RuleSet.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M sky/engine/core/css/StyleRule.h View 5 chunks +0 lines, -21 lines 0 comments Download
M sky/engine/core/css/StyleRule.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.h View 1 chunk +1 line, -6 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.cpp View 3 chunks +3 lines, -11 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser.h View 7 chunks +0 lines, -21 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 4 chunks +0 lines, -84 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParserTest.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
M sky/engine/core/css/parser/CSSGrammar.y View 14 chunks +1 line, -166 lines 0 comments Download
M sky/engine/core/css/parser/CSSTokenizer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/parser/CSSTokenizer-in.cpp View 9 chunks +6 lines, -41 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M sky/engine/core/dom/TreeScopeStyleSheetCollection.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/TreeScopeStyleSheetCollection.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
6 years ago (2014-12-16 02:27:55 UTC) #2
esprehn
6 years ago (2014-12-16 02:29:24 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
51d85c969c708594760f6b98ef31855653fea4e1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698