Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 807663006: [turbofan] Improve typing of ToBoolean. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve typing of ToBoolean. According to ES6 draft, revision 29 (2014-12-06), section 7.1.2, ToBoolean yields true for true, detectable receivers (the ES6 Object type), symbols and numbers except -0, +0 and NaN. R=hpayer@chromium.org Committed: https://crrev.com/1ed16c587e3187bad0405abad2403d6a2a8cbac3 Cr-Commit-Position: refs/heads/master@{#25915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/compiler/typer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL Reference documentation (current ES6 draft) for ToBoolean: https://people.mozilla.org/~jorendorff/es6-draft.html#sec-toboolean
6 years ago (2014-12-22 06:44:13 UTC) #2
Hannes Payer (out of office)
lgtm
6 years ago (2014-12-22 06:50:25 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as 1ed16c587e3187bad0405abad2403d6a2a8cbac3 (presubmit successful).
6 years ago (2014-12-22 07:21:59 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-22 07:22:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ed16c587e3187bad0405abad2403d6a2a8cbac3
Cr-Commit-Position: refs/heads/master@{#25915}

Powered by Google App Engine
This is Rietveld 408576698