Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: util/misc/clock_test.cc

Issue 807653002: win: static_cast to uint64_t rather than implicit_cast, to avoid warnings (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@in_range_cast
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/misc/clock_test.cc
diff --git a/util/misc/clock_test.cc b/util/misc/clock_test.cc
index d06afd6728aa196ca1e3de1ab9e2996aa6e1b6a3..9b1a07bd3346fd653f6b7476f5d441c5a65cb8b6 100644
--- a/util/misc/clock_test.cc
+++ b/util/misc/clock_test.cc
@@ -69,13 +69,13 @@ TEST(Clock, SleepNanoseconds) {
const uint64_t kTestData[] = {
0,
1,
- implicit_cast<uint64_t>(1E3), // 1 microsecond
- implicit_cast<uint64_t>(1E4), // 10 microseconds
- implicit_cast<uint64_t>(1E5), // 100 microseconds
- implicit_cast<uint64_t>(1E6), // 1 millisecond
- implicit_cast<uint64_t>(1E7), // 10 milliseconds
- implicit_cast<uint64_t>(2E7), // 20 milliseconds
- implicit_cast<uint64_t>(5E7), // 50 milliseconds
+ uint64_t(1E3), // 1 microsecond
Mark Mentovai 2014/12/15 23:41:33 I would use static_cast<uint64_t>(…) rather than u
scottmg 2014/12/15 23:45:48 Both done.
+ uint64_t(1E4), // 10 microseconds
+ uint64_t(1E5), // 100 microseconds
+ uint64_t(1E6), // 1 millisecond
+ uint64_t(1E7), // 10 milliseconds
+ uint64_t(2E7), // 20 milliseconds
+ uint64_t(5E7), // 50 milliseconds
};
for (size_t index = 0; index < arraysize(kTestData); ++index) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698