win: static_cast to uint64_t rather than implicit_cast, to avoid warnings

win: static_cast to uint64_t rather than implicit_cast, to avoid warnings

e.g.

FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\util\misc\util_test.clock_test.obj.rsp /c ..\..\util\misc\clock_test.cc /Foobj\util\misc\util_test.clock_test.obj /Fdobj\util\util_test.cc.pdb
d:\src\crashpad\crashpad\third_party\mini_chromium\mini_chromium\base\basictypes.h(49) : error C2220: warning treated as error - no 'object' file generated
        d:\src\crashpad\crashpad\util\misc\clock_test.cc(72) : see reference to function template instantiation 'To implicit_cast<uint64_t,double>(const From &)' being compiled
        with
        [
            To=uint64_t
,            From=double
        ]
d:\src\crashpad\crashpad\third_party\mini_chromium\mini_chromium\base\basictypes.h(49) : warning C4244: 'return' : conversion from 'const double' to 'uint64_t', possible loss of data

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9d38069f130593e5f8f22d16b268ba2374c8276d

[Mark Mentovai, 2014-12-15 23:41:33]

LGTM with this change

https://codereview.chromium.org/807653002/diff/1/util/misc/clock_test.cc
File util/misc/clock_test.cc (right):

https://codereview.chromium.org/807653002/diff/1/util/misc/clock_test.cc#newc...
util/misc/clock_test.cc:72: uint64_t(1E3),  // 1 microsecond
I would use static_cast<uint64_t>(…) rather than uint64_t(…) because of what the
style guide says about casting:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Casting

Update the CL description too.

[scottmg, 2014-12-15 23:45:48]

https://codereview.chromium.org/807653002/diff/1/util/misc/clock_test.cc
File util/misc/clock_test.cc (right):

https://codereview.chromium.org/807653002/diff/1/util/misc/clock_test.cc#newc...
util/misc/clock_test.cc:72: uint64_t(1E3),  // 1 microsecond
On 2014/12/15 23:41:33, Mark Mentovai wrote:
> I would use static_cast<uint64_t>(…) rather than uint64_t(…) because of what
the
> style guide says about casting:
> 
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Casting
> 
> Update the CL description too.

Both done.

[Mark Mentovai, 2014-12-15 23:46:16]

LGTM

[scottmg, 2014-12-16 00:21:04]

Patchset #3 (id:40001) has been deleted

[scottmg, 2014-12-16 00:21:17]

Committed patchset #2 (id:20001) manually as
9d38069f130593e5f8f22d16b268ba2374c8276d (presubmit successful).