Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: lib/Bitcode/NaCl/Reader/NaClBitcodeReader.h

Issue 807643002: Don't allow instructions/globals to use alignment > 2**29. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Fix nits. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/Bitcode/NaCl/Reader/NaClBitcodeReader.h
diff --git a/lib/Bitcode/NaCl/Reader/NaClBitcodeReader.h b/lib/Bitcode/NaCl/Reader/NaClBitcodeReader.h
index 2ea3ede537487445e316d07ba13a815dfb2067ca..b1cfbb0c3827a533419da991bb218d025fd621c2 100644
--- a/lib/Bitcode/NaCl/Reader/NaClBitcodeReader.h
+++ b/lib/Bitcode/NaCl/Reader/NaClBitcodeReader.h
@@ -248,6 +248,11 @@ public:
/// @returns true if an error occurred.
std::error_code ParseBitcodeInto(Module *M);
+ /// Convert alignment exponent (i.e. power of two (or zero)) to the
+ /// corresponding alignment to use. If alignment is too large, it generates
+ /// an error message and returns corresponding error code.
+ std::error_code getAlignmentValue(uint64_t Exponent, unsigned &Alignment);
+
private:
// Returns false if Header is acceptable.
bool AcceptHeader() const {

Powered by Google App Engine
This is Rietveld 408576698