chrome/test/data/webui/history_browsertest.js - Issue 807593005: Make downloads list keyboard shortcuts more consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/history_browsertest.js

Issue 807593005: Make downloads list keyboard shortcuts more consistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Apply feedback Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/history/history.js ('K') | « chrome/browser/resources/history/other_devices.js ('k') | ui/webui/resources/js/cr/ui/focus_grid.js » ('j') | ui/webui/resources/js/cr/ui/focus_grid.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/history_browsertest.js

diff --git a/chrome/test/data/webui/history_browsertest.js b/chrome/test/data/webui/history_browsertest.js

index 8aacf42126f8f40d756de950595e3fe37dc86e2a..03350b71cc180d4c46e048d6f577cb787de46d2e 100644

--- a/chrome/test/data/webui/history_browsertest.js

+++ b/chrome/test/data/webui/history_browsertest.js

@@ -787,7 +787,7 @@ TEST_F('HistoryWebUIRealBackendTest', 'basic', function() {

TEST_F('HistoryWebUIRealBackendTest', 'atLeastOneFocusable', function() {

var results = document.querySelectorAll('#results-display [tabindex="0"]');

- expectEquals(1, results.length);

+ expectGE(results.length, 1);

testDone();

});

@@ -1004,7 +1004,7 @@ TEST_F('HistoryWebUIDeleteProhibitedTest', 'deleteProhibited', function() {

TEST_F('HistoryWebUIDeleteProhibitedTest', 'atLeastOneFocusable', function() {

var results = document.querySelectorAll('#results-display [tabindex="0"]');

- expectEquals(1, results.length);

+ expectGE(results.length, 1);

testDone();

});