Make downloads list keyboard shortcuts more consistent.

chrome/browser/resources/history/other_devices.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview The section of the history page that shows tabs from sessions
                  on other devices.
  */
 
 ///////////////////////////////////////////////////////////////////////////////
@@ skipping 409 matching lines @@
 DevicesView.prototype.increaseRowHeight = function(row, height) {
   for (var i = this.rowHeights_.length; i <= row; i++)
     this.rowHeights_.push(NB_ENTRIES_OTHER_ROWS_COLUMN);
   this.rowHeights_[row] += height;
   this.displayResults_();
 };
 
 // DevicesView, Private -------------------------------------------------------
 
 /**
+ * Provides an implementation for a single column grid.
+ * @constructor
+ * @param {Element} rowElement The element representing this row.
+ * @param {Node} boundary Focus events are ignored outside of this node.
+ * @extends {cr.ui.FocusRow}
+ */
+DevicesView.SingleColumnFocusRow = function(rowElement, boundary) {
+  rowElement.__proto__ = DevicesView.SingleColumnFocusRow.prototype;
+  rowElement.decorate(boundary);
+  return rowElement;
+};
+
+DevicesView.SingleColumnFocusRow.prototype = {
+  __proto__: cr.ui.FocusRow.prototype,
+
+  /** @override */
+  decorate: function(boundary, opt_delegate) {
+    cr.ui.FocusRow.prototype.decorate.apply(this, arguments);
+    this.addFocusableElement(this);
+  },
+
+  /** @override */
+  getEquivalentElement: function(element) {
+    return this;
+  },
+};
+
+/**
  * Update the page with results.
  * @private
  */
 DevicesView.prototype.displayResults_ = function() {
   this.clearDOM();
   var resultsFragment = document.createDocumentFragment();
   if (this.devices_.length == 0)
     return;
 
   // We'll increase to 0 as we create the first row.
@@ skipping 32 matching lines @@
     if (tabs[i].scrollWidth <= tabs[i].clientWidth)
       tabs[i].title = '';
   }
 
   this.resultDiv_.appendChild(
       createElementWithClassName('div', 'other-devices-bottom'));
 
   this.focusGrids_.forEach(function(grid) { grid.destroy(); });
   this.focusGrids_.length = 0;
 
-  var singleColumn = function(e) { return [e]; };
-
   var devices = this.resultDiv_.querySelectorAll('.device-contents');
   for (var i = 0; i < devices.length; ++i) {
     var rows = devices[i].querySelectorAll('.device-tab-entry, button');
     if (!rows.length)
       continue;
 
-    var grid = new cr.ui.FocusGrid(devices[i]);
-    grid.setGrid(Array.prototype.map.call(rows, singleColumn));
+    var grid = new cr.ui.FocusGrid();
+    for (var i = 0; i < rows.length; ++i)

[Dan Beam, 2015/01/24 02:37:08]

nit: curlies

[hcarmona, 2015/01/27 18:30:40]

Done.

+      grid.addRow(new DevicesView.SingleColumnFocusRow(rows[i], devices[i]));
     this.focusGrids_.push(grid);
   }
 };
 
 /**
  * Sets the menu model data. An empty list means that either there are no
  * foreign sessions, or tab sync is disabled for this profile.
  * |isTabSyncEnabled| makes it possible to distinguish between the cases.
  *
  * @param {Array} sessionList Array of objects describing the sessions
@@ skipping 48 matching lines @@
 
   var doSearch = function(e) {
     devicesView.setSearchText($('search-field').value);
   };
   $('search-field').addEventListener('search', doSearch);
   $('search-button').addEventListener('click', doSearch);
 }
 
 // Add handlers to HTML elements.
 document.addEventListener('DOMContentLoaded', load);