Fix ChromeRenderViewObserver::DidStopLoading to be OOPIF compatible.

chrome/renderer/chrome_render_view_observer.cc

Index: chrome/renderer/chrome_render_view_observer.cc
diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc
index a2e1b9aecc961cc413ebc94187a186cdd02103b8..aa949bb1a3e3a38688dd3d8a4931ee7c1414f1e2 100644
--- a/chrome/renderer/chrome_render_view_observer.cc
+++ b/chrome/renderer/chrome_render_view_observer.cc
@@ -334,16 +334,21 @@ void ChromeRenderViewObserver::DidStartLoading() {
 
 void ChromeRenderViewObserver::DidStopLoading() {
   WebFrame* main_frame = render_view()->GetWebView()->mainFrame();
-  GURL osdd_url = main_frame->document().openSearchDescriptionURL();
-  if (!osdd_url.is_empty()) {
-    Send(new ChromeViewHostMsg_PageHasOSDD(
-        routing_id(), main_frame->document().url(), osdd_url,
-        search_provider::AUTODETECTED_PROVIDER));
-  }
 
-  // Don't capture pages including refresh meta tag.
-  if (HasRefreshMetaTag(main_frame))
-    return;
+  // Only WebLocalFrames host the document associated with a frame and need to
+  // process meta or OSDD tags.
+  if (main_frame->isWebLocalFrame()) {
+    GURL osdd_url = main_frame->document().openSearchDescriptionURL();
+    if (!osdd_url.is_empty()) {
+      Send(new ChromeViewHostMsg_PageHasOSDD(
+          routing_id(), main_frame->document().url(), osdd_url,
+          search_provider::AUTODETECTED_PROVIDER));
+    }
+
+    // Don't capture pages including refresh meta tag.
+    if (HasRefreshMetaTag(main_frame))
+      return;
+  }
 
   CapturePageInfoLater(

[Lei Zhang, 2014/12/16 23:46:57]

I think you want this to be for WebLocalFrame only as well? This eventually goes
to ChromeRenderViewObserver::CapturePageInfo(), which currently first checks and
ignores WebRemoteFrames.

[nasko, 2014/12/16 23:48:59]

I'm not certain and the CapturePageInfo already has a check for remote frames,
which is tagged separately. Do you think it is worth just returning early then?

[Lei Zhang, 2014/12/17 00:14:20]

It looks like creis@ has plans to move the CapturePageInfo() code to the browser
process eventually, so I think the whole thing can go inside the if
(isWebLocalFrame()) block. The HasRefreshMetaTag() and CapturePageInfoLater()
calls are related, so it feels weird to separate them.

I don't know if the OSDD portion is correct. Do we care about OSDD tags in
remote frames?

       false,  // preliminary_capture