Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 807583003: Revert of Include MTP devices in Cloud Import happiness. (Closed)

Created:
6 years ago by samuong
Modified:
6 years ago
Reviewers:
mtomasz, Steve McKay
CC:
chromium-reviews, tfarina, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Include MTP devices in Cloud Import happiness. (patchset #9 id:160001 of https://codereview.chromium.org/778123006/) Reason for revert: seems to be causing crashes on chrome os: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/53530 https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/35254 Original issue's description: > Include MTP devices in Cloud Import happiness. > Nuke "VolumeManager.isType". > Add test coverage of importer_common methods. > Make all "DCIM" dir-name matching case-insensitive. > > BUG=420680 > TEST=browser_test: FileManagerJsTest.* > > Committed: https://crrev.com/15d1aae4da7783607df3fac2d38198e817cf6fa0 > Cr-Commit-Position: refs/heads/master@{#308414} TBR=mtomasz@chromium.org,smckay@chromium.org NOTREECHECKS=true NOTRY=true BUG=420680 Committed: https://crrev.com/455f193f3912bbd7d678fb36a2165629931ee7ab Cr-Commit-Position: refs/heads/master@{#308442}

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
samuong
Created Revert of Include MTP devices in Cloud Import happiness.
6 years ago (2014-12-15 22:24:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807583003/1
6 years ago (2014-12-15 22:25:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 22:27:04 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-15 22:27:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/455f193f3912bbd7d678fb36a2165629931ee7ab
Cr-Commit-Position: refs/heads/master@{#308442}

Powered by Google App Engine
This is Rietveld 408576698