Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issue 807573004: [turbofan] Turn IrOpcode::IsXXX() into range checks. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn IrOpcode::IsXXX() into range checks. TEST=unittests R=dcarney@chromium.org Committed: https://crrev.com/dd6ce126457fa1e5fe65a3ae370e5ca4e1fd93e7 Cr-Commit-Position: refs/heads/master@{#26079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -49 lines) Patch
M src/compiler/opcodes.h View 1 chunk +12 lines, -45 lines 0 comments Download
M test/unittests/compiler/opcodes-unittest.cc View 2 chunks +101 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-15 14:40:55 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-15 14:41:45 UTC) #2
dcarney
lgtm
5 years, 11 months ago (2015-01-15 14:42:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807573004/1
5 years, 11 months ago (2015-01-15 14:43:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 15:07:36 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 15:07:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd6ce126457fa1e5fe65a3ae370e5ca4e1fd93e7
Cr-Commit-Position: refs/heads/master@{#26079}

Powered by Google App Engine
This is Rietveld 408576698