Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 807553002: Roll libwebp to v0.4.2 (latest stable) to fix annoying build warning. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Roll libwebp to v0.4.2 (latest stable) to fix annoying build warning. This warning should now go away: ../../third_party/externals/libwebp/src/enc/quant.c:105:23: warning: unused variable 'kCoeffThresh' [-Wunused-const-variable] static const uint16_t kCoeffThresh[16] = { BUG=skia: Committed: https://skia.googlesource.com/skia/+/e655557a551c545f4153b0764269298cd01cd0c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gyp/libwebp.gyp View 5 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein
6 years ago (2014-12-15 20:00:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807553002/1
6 years ago (2014-12-15 20:00:42 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-15 20:00:43 UTC) #5
caryclark
lgtm
6 years ago (2014-12-15 20:10:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e655557a551c545f4153b0764269298cd01cd0c0
6 years ago (2014-12-15 20:11:53 UTC) #7
mtklein
6 years ago (2014-12-15 20:22:22 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/795823005/ by mtklein@google.com.

The reason for reverting is: uses __builtins not available on all our compilers.

Powered by Google App Engine
This is Rietveld 408576698