chrome/chrome_tests.gypi - Issue 807503004: While trying to enable webview sign-in by default, I found a bunch of issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests.gypi

Issue 807503004: While trying to enable webview sign-in by default, I found a bunch of issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable tests for cros in gyp file Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc ('K') | « chrome/browser/ui/zoom/zoom_controller_browsertest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_tests.gypi

diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi

index 38801481aeab4ab3fb6b6245d715e857ffe54feb..d41b33fb35a283998a81c608e7320225a578aeee 100644

--- a/chrome/chrome_tests.gypi

+++ b/chrome/chrome_tests.gypi

@@ -586,6 +586,7 @@

'browser/ui/autofill/test_generated_credit_card_bubble_controller.h',

'browser/ui/blocked_content/popup_blocker_browsertest.cc',

'browser/ui/bookmarks/bookmark_browsertest.cc',

+ 'browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc',

'browser/ui/browser_browsertest.cc',

'browser/ui/browser_close_browsertest.cc',

'browser/ui/browser_command_controller_browsertest.cc',

@@ -2112,6 +2113,8 @@

'browser/profiles/profile_list_desktop_browsertest.cc',

'browser/service_process/service_process_control_browsertest.cc',

'browser/signin/signin_browsertest.cc',

+ # bookmark sign in promo not used on chromeos

+ 'browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc',

# chromeos does not use cross-platform panels

'browser/ui/panels/panel_extension_browsertest.cc',

# chromeos does not use the desktop user manager

@@ -2293,6 +2296,7 @@

'sources!': [

'browser/policy/cloud/component_cloud_policy_browsertest.cc',

'browser/prefs/pref_hash_browsertest.cc',

+ 'browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc',

}],

['os_posix == 1 and OS != "mac" and OS != "android"', {