chrome/browser/ui/webui/signin/inline_login_handler_impl.cc - Issue 807503004: While trying to enable webview sign-in by default, I found a bunch of issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 807503004: While trying to enable webview sign-in by default, I found a bunch of issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable tests for cros in gyp file Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc ('K') | « chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc ('k') | chrome/browser/ui/webui/signin/inline_login_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

index f9452bda3eab3f66a3e4803747372ad2822f07c1..89f80a950abed4d332d275856439cbcc20177f94 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

@@ -240,6 +240,7 @@ InlineLoginHandlerImpl::InlineLoginHandlerImpl()

InlineLoginHandlerImpl::~InlineLoginHandlerImpl() {}

+// This method is not called with webview sign in enabled.

void InlineLoginHandlerImpl::DidCommitProvisionalLoadForFrame(

content::RenderFrameHost* render_frame_host,

const GURL& url,

@@ -294,6 +295,11 @@ void InlineLoginHandlerImpl::CompleteLogin(const base::ListValue* args) {

return;

}

+ // This value exists only for webview sign in.

+ bool trusted = false;

+ if (dict->GetBoolean("trusted", &trusted))

+ confirm_untrusted_signin_ = !trusted;

base::string16 email_string16;

dict->GetString("email", &email_string16);

DCHECK(!email_string16.empty());