While trying to enable webview sign-in by default, I found a bunch of issues

chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/webui/signin/inline_login_ui.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
 #include "chrome/browser/ui/webui/signin/login_ui_test_utils.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/test_browser_window.h"
 #include "chrome/test/base/test_chrome_web_ui_controller_factory.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/ui_test_utils.h"
+#include "components/signin/core/common/profile_management_switches.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/session_storage_namespace.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui_controller.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_navigation_observer.h"
+#include "extensions/browser/guest_view/guest_view_manager.h"
 #include "google_apis/gaia/fake_gaia.h"
 #include "google_apis/gaia/gaia_switches.h"
 #include "net/base/url_util.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "net/test/embedded_test_server/http_request.h"
 #include "net/test/embedded_test_server/http_response.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::_;
 using ::testing::Invoke;
 using ::testing::InvokeWithoutArgs;
 
 using login_ui_test_utils::ExecuteJsToSigninInSigninFrame;
 using login_ui_test_utils::WaitUntilUIReady;
 
 namespace {
 
 struct ContentInfo {
-  ContentInfo(int pid, content::StoragePartition* storage_partition) {
+  ContentInfo(content::WebContents* contents,
+              int pid,
+              content::StoragePartition* storage_partition) {
+    this->contents = contents;
     this->pid = pid;
     this->storage_partition = storage_partition;
   }
 
+  content::WebContents* contents;
   int pid;
   content::StoragePartition* storage_partition;
 };
 
 ContentInfo NavigateAndGetInfo(
     Browser* browser,
     const GURL& url,
     WindowOpenDisposition disposition) {
   ui_test_utils::NavigateToURLWithDisposition(
       browser, url, disposition,
       ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
   content::WebContents* contents =
       browser->tab_strip_model()->GetActiveWebContents();
   content::RenderProcessHost* process = contents->GetRenderProcessHost();
-  return ContentInfo(process->GetID(), process->GetStoragePartition());
+  return ContentInfo(contents, process->GetID(),
+                     process->GetStoragePartition());
 }
 
 // Returns a new WebUI object for the WebContents from |arg0|.
 ACTION(ReturnNewWebUI) {
   return new content::WebUIController(arg0);
 }
 
 // Mock the TestChromeWebUIControllerFactory::WebUIProvider to prove that we are
 // not called as expected.
 class FooWebUIProvider
     : public TestChromeWebUIControllerFactory::WebUIProvider {
  public:
   MOCK_METHOD2(NewWebUI, content::WebUIController*(content::WebUI* web_ui,
                                                    const GURL& url));
 };
 
 class MockLoginUIObserver : public LoginUIService::Observer {
  public:
   MOCK_METHOD0(OnUntrustedLoginUIShown, void());
 };
 
 const char kFooWebUIURL[] = "chrome://foo/";
 
+bool AddToSet(std::set<content::WebContents*>* set,
+              content::WebContents* web_contents) {
+  set->insert(web_contents);
+  return false;
+}
+
 }  // namespace
 
 class InlineLoginUIBrowserTest : public InProcessBrowserTest {
  public:
   InlineLoginUIBrowserTest() {}
 };
 
 #if defined(OS_LINUX) || defined(OS_WIN)
 // crbug.com/422868
 #define MAYBE_DifferentStorageId DISABLED_DifferentStorageId
 #else
 #define MAYBE_DifferentStorageId DifferentStorageId
 #endif
 IN_PROC_BROWSER_TEST_F(InlineLoginUIBrowserTest, MAYBE_DifferentStorageId) {
-  GURL test_url = ui_test_utils::GetTestUrl(
-      base::FilePath(base::FilePath::kCurrentDirectory),
-      base::FilePath(FILE_PATH_LITERAL("title1.html")));
+  if (switches::IsEnableWebviewBasedSignin()) {
+    ContentInfo info = NavigateAndGetInfo(
+        browser(),
+        signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
+        CURRENT_TAB);
+    WaitUntilUIReady(browser());
 
-  ContentInfo info1 =
-      NavigateAndGetInfo(browser(), test_url, CURRENT_TAB);
-  ContentInfo info2 = NavigateAndGetInfo(
-      browser(),
-      signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
-      CURRENT_TAB);
-  NavigateAndGetInfo(browser(), test_url, CURRENT_TAB);
-  ContentInfo info3 = NavigateAndGetInfo(
-      browser(),
-      signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
-      NEW_FOREGROUND_TAB);
+    // Make sure storage partition of embedded webview is different from
+    // parent.
+    std::set<content::WebContents*> set;
+    extensions::GuestViewManager* manager =
+        extensions::GuestViewManager::FromBrowserContext(
+            info.contents->GetBrowserContext());
+    manager->ForEachGuest(info.contents, base::Bind(&AddToSet, &set));
+    ASSERT_EQ(1u, set.size());
+    content::WebContents* webview_contents = *set.begin();
+    content::RenderProcessHost* process =
+        webview_contents->GetRenderProcessHost();
+    ASSERT_NE(info.pid, process->GetID());
+    ASSERT_NE(info.storage_partition, process->GetStoragePartition());
+  } else {
+    GURL test_url = ui_test_utils::GetTestUrl(
+        base::FilePath(base::FilePath::kCurrentDirectory),
+        base::FilePath(FILE_PATH_LITERAL("title1.html")));
 
-  // The info for signin should be the same.
-  ASSERT_EQ(info2.storage_partition, info3.storage_partition);
-  // The info for test_url and signin should be different.
-  ASSERT_NE(info1.storage_partition, info2.storage_partition);
+    ContentInfo info1 =
+        NavigateAndGetInfo(browser(), test_url, CURRENT_TAB);
+    ContentInfo info2 = NavigateAndGetInfo(
+        browser(),
+        signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
+        CURRENT_TAB);
+    NavigateAndGetInfo(browser(), test_url, CURRENT_TAB);
+    ContentInfo info3 = NavigateAndGetInfo(
+        browser(),
+        signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
+        NEW_FOREGROUND_TAB);
+
+    // The info for signin should be the same.
+    ASSERT_EQ(info2.storage_partition, info3.storage_partition);
+    // The info for test_url and signin should be different.
+    ASSERT_NE(info1.storage_partition, info2.storage_partition);
+  }
 }
 
 IN_PROC_BROWSER_TEST_F(InlineLoginUIBrowserTest, OneProcessLimit) {
   GURL test_url_1 = ui_test_utils::GetTestUrl(
       base::FilePath(base::FilePath::kCurrentDirectory),
       base::FilePath(FILE_PATH_LITERAL("title1.html")));
   GURL test_url_2 = ui_test_utils::GetTestUrl(
       base::FilePath(base::FilePath::kCurrentDirectory),
       base::FilePath(FILE_PATH_LITERAL("data:text/html,Hello world!")));
 
@@ skipping 135 matching lines @@
 #if !defined(OS_CHROMEOS)
 IN_PROC_BROWSER_TEST_F(InlineLoginUISafeIframeBrowserTest,
     ConfirmationRequiredForNonsecureSignin) {
   FakeGaia fake_gaia;
   fake_gaia.Initialize();
 
   embedded_test_server()->RegisterRequestHandler(
       base::Bind(&FakeGaia::HandleRequest,
                  base::Unretained(&fake_gaia)));
   fake_gaia.SetFakeMergeSessionParams(
-      "email", "fake-sid-cookie", "fake-lsid-cookie");
+      "email@gmail.com", "fake-sid-cookie", "fake-lsid-cookie");
 
   // Navigates to the Chrome signin page which loads the fake gaia auth page.
   // Since the fake gaia auth page is served over HTTP, thus expects to see an
   // untrusted signin confirmation dialog upon submitting credentials below.
   ui_test_utils::NavigateToURL(
       browser(), signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false));
   WaitUntilUIReady(browser());
 
   MockLoginUIObserver observer;
   LoginUIServiceFactory::GetForProfile(browser()->profile())
       ->AddObserver(&observer);
   base::RunLoop run_loop;
   EXPECT_CALL(observer, OnUntrustedLoginUIShown())
       .WillOnce(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit));
 
-  ExecuteJsToSigninInSigninFrame(browser(), "email", "password");
+  ExecuteJsToSigninInSigninFrame(browser(), "email@gmail.com", "password");
   run_loop.Run();
   base::MessageLoop::current()->RunUntilIdle();
 }
 #endif // OS_CHROMEOS