Remove the use of :-webkit-full-screen-document.

Remove the use of :-webkit-full-screen-document.

This is a pseudo class that is not implemented by Gecko nor IE, while the
ancestor variant is implemented prefixed by Gecko.

It would be good to remove this. As a first step get rid of the use in the
UA style.

This selector:

:root:-webkit-full-screen-document:not(:-webkit-full-screen)

matches a subset of this:

:root:-webkit-full-screen-ancestor

which means we can just remove the former.

Use counters are added for fullscreen pseudo classes. The ancestor and
document variants are no longer in the spec. Let's see if we can remove them
further down the road.

R=jchaffraix@chromium.org,philipj@opera.com
BUG=442239
TEST=LayoutTests/fullscreen/
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187369

[Julien - ping for review, 2014-12-15 18:27:41]

lgtm, I couldn't find why the -webkit-full-screen-document was added in the
first place so we may discover it.

Also I don't think your explanation is fine:

:root:-webkit-full-screen-document:not(:-webkit-full-screen) will match the root
of the browsing context containing the fullscreen element.

:root:-webkit-full-screen-ancestor will match the root of any browsing context
in the browsing context chain (-webkit-full-screen-ancestor jumps across
iframes).

Thus it's safe to remove it as the former a subset of the latter.

[rune, 2014-12-16 14:31:13]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-12-16 14:32:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807473002/1

[commit-bot: I haz the power, 2014-12-16 14:32:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 14:32:16]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 561.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
74dec3374caccffd6d88d64e22a2178c088d5f38..6560c935509b79f3af365585057b862b7a55a41d
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -561,6 +561,8 @@ public:
         MixedContentPrefetch = 617,
         MixedContentVideo = 618,
         CORSCredentialedNullOriginAccessAllowed = 619,
+        CSSSelectorPseudoFullScreenDocument = 620,
+        CSSSelectorPseudoFullScreenAncestor = 621,
 
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.

[philipj_slow, 2014-12-16 14:47:44]

LGTM. With fullscreen moved to the top layer, will it ever be possible for an
ancestor of the fullscreen element to be visible? If it isn't, then
:-webkit-full-screen-ancestor could only affect inherited properties like color,
right?

[rune, 2014-12-16 15:24:14]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-12-16 15:24:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807473002/20001

[Julien - ping for review, 2014-12-16 16:56:12]

On 2014/12/16 at 14:47:44, philipj wrote:
> LGTM. With fullscreen moved to the top layer, will it ever be possible for an
ancestor of the fullscreen element to be visible? If it isn't, then
:-webkit-full-screen-ancestor could only affect inherited properties like color,
right?

The backdrop can be made transparent so you can see the page underneath.

[commit-bot: I haz the power, 2014-12-16 18:04:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 18:04:56]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42086)

[rune, 2014-12-16 18:53:39]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-12-16 18:54:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807473002/20001

[commit-bot: I haz the power, 2014-12-16 20:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 20:45:36]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42125)

[philipj_slow, 2014-12-16 23:08:58]

On 2014/12/16 16:56:12, Julien Chaffraix - OOO til 1-1 wrote:
> On 2014/12/16 at 14:47:44, philipj wrote:
> > LGTM. With fullscreen moved to the top layer, will it ever be possible for
an
> ancestor of the fullscreen element to be visible? If it isn't, then
> :-webkit-full-screen-ancestor could only affect inherited properties like
color,
> right?
> 
> The backdrop can be made transparent so you can see the page underneath.

Ah, right.

[rune, 2014-12-17 07:54:32]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-12-17 07:55:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807473002/20001

[commit-bot: I haz the power, 2014-12-17 07:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 07:55:29]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 565.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
e47cce852bd2eb5bd0e22aa59d5218f208e37f1e..41fb8916cbaea614f44e16de94363381996fa2c7
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -565,6 +565,8 @@ public:
         ShadowRootGetElementsByClassName = 623,
         ShadowRootGetElementsByTagName = 624,
         ShadowRootGetElementsByTagNameNS = 625,
+        CSSSelectorPseudoFullScreenDocument = 626,
+        CSSSelectorPseudoFullScreenAncestor = 627,
 
         // Add new features immediately above this line. Don't change assigned
         // numbers of any item, and don't reuse removed slots.

[philipj_slow, 2014-12-17 08:21:04]

Since you have to rebase this again, can you also add a
CSSSelectorPseudoFullScreen entry for :-webkit-full-screen? We don't have
:fullscreen yet, but it's nice to have the data over time when considering
removal of :-webkit-full-screen.

[rune, 2014-12-17 09:32:34]

On 2014/12/17 at 08:21:04, philipj wrote:
> Since you have to rebase this again, can you also add a
CSSSelectorPseudoFullScreen entry for :-webkit-full-screen? We don't have
:fullscreen yet, but it's nice to have the data over time when considering
removal of :-webkit-full-screen.

Done

[rune, 2014-12-17 09:32:41]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-12-17 09:33:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807473002/60001

[commit-bot: I haz the power, 2014-12-17 11:47:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 11:47:18]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42286)

[rune, 2014-12-17 11:50:30]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-12-17 11:51:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807473002/60001

[commit-bot: I haz the power, 2014-12-17 12:26:59]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187369