Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 807463003: Use FrameMatchingPredicate() to find RenderFrameHosts in ExtensionWebUITest. (Closed)

Created:
6 years ago by alexmos
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Charlie Reis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use FrameMatchingPredicate() to find RenderFrameHosts in ExtensionWebUITest. When looking for a RFH by last committed URL, there is no need to do a ForEach with a private FindFrame() predicate, since that logic is already available from a public FrameMatchingPredicate method in browser_test_utils. BUG= Committed: https://crrev.com/c515c08b4d0b62a3b24540b6c2fd6db86fdfa250 Cr-Commit-Position: refs/heads/master@{#308458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M chrome/browser/extensions/extension_webui_apitest.cc View 2 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alexmos
asargent@, could you please review this CL? I was working on another CL, and this ...
6 years ago (2014-12-15 21:53:14 UTC) #2
asargent_no_longer_on_chrome
lgtm
6 years ago (2014-12-15 22:49:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807463003/1
6 years ago (2014-12-15 22:53:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 23:33:08 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 23:34:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c515c08b4d0b62a3b24540b6c2fd6db86fdfa250
Cr-Commit-Position: refs/heads/master@{#308458}

Powered by Google App Engine
This is Rietveld 408576698