Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: chrome/test/remoting/remote_desktop_browsertest.cc

Issue 807343002: Adding the first set of remote test cases and associated framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/remoting/remote_desktop_browsertest.cc
diff --git a/chrome/test/remoting/remote_desktop_browsertest.cc b/chrome/test/remoting/remote_desktop_browsertest.cc
index 80160d5312f52ce1cb223806d121ff9b81e99a34..d2b216ec25f7d058044d263271456543a45bdcea 100644
--- a/chrome/test/remoting/remote_desktop_browsertest.cc
+++ b/chrome/test/remoting/remote_desktop_browsertest.cc
@@ -29,7 +29,7 @@
namespace remoting {
RemoteDesktopBrowserTest::RemoteDesktopBrowserTest()
- : extension_(NULL) {
+ : remote_test_helper_(NULL), extension_(NULL) {
Jamie 2014/12/17 03:15:40 Use nullptr in new code (might as well update |ext
Mike Meade 2014/12/18 18:54:24 Done.
}
RemoteDesktopBrowserTest::~RemoteDesktopBrowserTest() {}
@@ -72,7 +72,7 @@ void RemoteDesktopBrowserTest::OpenClientBrowserPage() {
// Open the client browser page in a new tab
ui_test_utils::NavigateToURLWithDisposition(
browser(),
- GURL(http_server() + "/clientpage.html"),
+ GURL(http_server() + "/client.html"),
NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);
// Save this web content for later reference
@@ -80,6 +80,9 @@ void RemoteDesktopBrowserTest::OpenClientBrowserPage() {
// Go back to the previous tab that has chromoting opened
browser()->tab_strip_model()->SelectPreviousTab();
+
+ // Create the RemoteTestHelper object to use.
+ remote_test_helper_ = RemoteTestHelper(client_web_content_);
Jamie 2014/12/17 03:15:40 I don't know what the style guide has to say about
Mike Meade 2014/12/18 18:54:24 Done.
}
bool RemoteDesktopBrowserTest::HtmlElementVisible(const std::string& name) {

Powered by Google App Engine
This is Rietveld 408576698