Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 807313003: Crash with an error message when ICU data files are missing (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Crash with an error message when ICU data files are missing Before, we'd just crash. BUG=v8:3348 R=svenpanne@chromium.org LOG=n Committed: https://crrev.com/b34a7d23d2be927bb41822919eaa983d89872cb5 Cr-Commit-Position: refs/heads/master@{#25877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/i18n.cc View 4 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-17 08:22:42 UTC) #1
Sven Panne
lgtm
6 years ago (2014-12-18 08:28:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807313003/1
6 years ago (2014-12-18 08:29:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 08:56:47 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-18 18:05:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b34a7d23d2be927bb41822919eaa983d89872cb5
Cr-Commit-Position: refs/heads/master@{#25877}

Powered by Google App Engine
This is Rietveld 408576698