base: Add free list implementation to browser-wide discardable memory system.

base/memory/discardable_memory_shmem.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_MEMORY_DISCARDABLE_MEMORY_SHMEM_H_
 #define BASE_MEMORY_DISCARDABLE_MEMORY_SHMEM_H_
 
 #include "base/memory/discardable_memory.h"
 
 #include "base/memory/discardable_memory_manager.h"
 
 namespace base {
-class DiscardableSharedMemory;
+class DiscardableMemoryShmemChunk;
 
 namespace internal {
 
 class DiscardableMemoryShmem
     : public DiscardableMemory,
       public internal::DiscardableMemoryManagerAllocation {
  public:
   explicit DiscardableMemoryShmem(size_t bytes);
   virtual ~DiscardableMemoryShmem();
 
   static void ReleaseFreeMemory();
 
   static void PurgeForTesting();
 
   bool Initialize();
 
   // Overridden from DiscardableMemory:
   virtual DiscardableMemoryLockStatus Lock() override;
   virtual void Unlock() override;
   virtual void* Memory() const override;
 
   // Overridden from internal::DiscardableMemoryManagerAllocation:
   virtual bool AllocateAndAcquireLock() override;
   virtual void ReleaseLock() override;
   virtual void Purge() override;
   virtual bool IsMemoryResident() const override;
 
  private:
   const size_t bytes_;
-  scoped_ptr<DiscardableSharedMemory> shared_memory_;
+  scoped_ptr<DiscardableMemoryShmemChunk> chunk_;

[danakj, 2014/12/18 21:40:50]

What is the point of wrapping DiscardableSharedMemory in this new interface?

[reveman, 2014/12/19 00:49:54]

Each DiscardableSharedMemory instance is used for multiple DiscardableMemory
instances. We have X number of DiscardableSharedMemory instances and Y number of
DiscardableMemoryShmemChunk instances for each DiscardableSharedMemory instance.

DiscardableMemoryShmemChunk will eventually be removed and we'll just have X
DiscardableSharedMemory and Y DiscardableMemory instances. See the comment in
discardable_memory_shmem_allocator.h. I just need to first enable this code and
remove the old emulated discardable memory system before I can do this.

[danakj, 2014/12/19 21:08:08]

Sorry this explanation confuses me. Specifically DiscardableSharedMemory is
created and put in a scoped_ptr, then Passed to and wrapped in a new scoped_ptr
inside a DiscardableMemoryShmemChunkImpl. So these seem to be 1:1. So what do
you mean by there are X DiscardableSharedMemory and Y
DiscardableMemoryShmemChunk?

[reveman, 2014/12/19 22:16:03]

It's wrapped in a linked_ptr (See
DiscardableSharedMemoryHeap::Span::shared_memory_), so it's ref counted. That
could be wrapped in a RefCounted type instead if linked_ptr is not efficient
enough. I'm not sure that's necessary though.

   bool is_locked_;
 
   DISALLOW_COPY_AND_ASSIGN(DiscardableMemoryShmem);
 };
 
 }  // namespace internal
 }  // namespace base
 
 #endif  // BASE_MEMORY_DISCARDABLE_MEMORY_SHMEM_H_