Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 8073011: Merge 101979 - promo_resource_service fixes/cleanup for promos. (Closed)

Created:
9 years, 2 months ago by achuithb
Modified:
9 years, 2 months ago
Reviewers:
achuithb
CC:
chromium-reviews, estade+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 101979 - promo_resource_service fixes/cleanup for promos. Remove is_synced check in CanShowPromo. Add support for additional question param max_group_number. Fix a bug where group was reset everytime the promo resource was fetched. Breakup UnpackPromoSignal to a number of smaller helper functions for clarity, and so they can be individually unit-tested. Put all the logic of whether to display a promo into CanShowPromo. Get rid of unnecessary namespace PromoResourceServiceUtil. Make IsBuildTargeted private. Make GetChannel a private function in anonymous scope to consolidate duplicated comments/code. Delete unused web_resource_cache_. BUG=93201 TEST=Only relevant change is removal of is_synced check in CanShowPromo. Review URL: http://codereview.chromium.org/7655008 TBR=achuith@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -161 lines) Patch
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.h View 8 chunks +59 lines, -22 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.cc View 8 chunks +212 lines, -120 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service_unittest.cc View 5 chunks +29 lines, -10 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
achuithb
9 years, 2 months ago (2011-09-28 23:53:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698