Source/bindings/scripts/v8_utilities.py - Issue 807263007: IDL: Add forEach() method to iterable<>/maplike<>/setlike<> interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_utilities.py

Issue 807263007: IDL: Add forEach() method to iterable<>/maplike<>/setlike<> interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: adjust test expectations Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_utilities.py

diff --git a/Source/bindings/scripts/v8_utilities.py b/Source/bindings/scripts/v8_utilities.py

index ba5dd6f31290cdc1522d12cf24bfdcf9739192ff..6df63c624cebb3d057e9069d0d8453f21997c37c 100644

--- a/Source/bindings/scripts/v8_utilities.py

+++ b/Source/bindings/scripts/v8_utilities.py

@@ -201,6 +201,7 @@ CALL_WITH_ARGUMENTS = {

'ActiveWindow': 'callingDOMWindow(info.GetIsolate())',

'FirstWindow': 'enteredDOMWindow(info.GetIsolate())',

'Document': 'document',

+ 'ThisValue': 'ScriptValue(scriptState, info.This())',

}

# List because key order matters, as we want arguments in deterministic order

CALL_WITH_VALUES = [

@@ -210,6 +211,7 @@ CALL_WITH_VALUES = [

'ActiveWindow',

'FirstWindow',

'Document',

+ 'ThisValue',

]

« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/tests/results/core/V8TestInterface2.cpp » ('j') | no next file with comments »