Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: Source/bindings/scripts/v8_utilities.py

Issue 807263007: IDL: Add forEach() method to iterable<>/maplike<>/setlike<> interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: remove FIXMEs about missing forEach() Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_utilities.py
diff --git a/Source/bindings/scripts/v8_utilities.py b/Source/bindings/scripts/v8_utilities.py
index c4935d79d17f692a3c5eba27ac07d598fc5a8d93..f09cccab89150c22f1928fb7559e5d752e2c7a84 100644
--- a/Source/bindings/scripts/v8_utilities.py
+++ b/Source/bindings/scripts/v8_utilities.py
@@ -201,6 +201,7 @@ CALL_WITH_ARGUMENTS = {
'ActiveWindow': 'callingDOMWindow(info.GetIsolate())',
'FirstWindow': 'enteredDOMWindow(info.GetIsolate())',
'Document': 'document',
+ 'ThisValue': 'ScriptValue(scriptState, info.This())',
haraken 2015/01/27 01:56:30 Just to confirm: Are you sure that we should use i
Jens Widell 2015/01/27 07:19:23 No, I'm not sure. What's the difference between th
haraken 2015/01/27 08:47:11 info.Holder() points to a reciever, and info.This(
}
# List because key order matters, as we want arguments in deterministic order
CALL_WITH_VALUES = [
@@ -210,6 +211,7 @@ CALL_WITH_VALUES = [
'ActiveWindow',
'FirstWindow',
'Document',
+ 'ThisValue',
]

Powered by Google App Engine
This is Rietveld 408576698