Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 807263003: Instrumenting opening password database to find jank (Closed)

Created:
6 years ago by vadimt
Modified:
6 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, pavely
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumenting opening password database to find jank. This database opening happens in UI thread. Checking what jankiness this causes. Background: one of jankiness investigations (crbug.com/426272) came to a conclusion that the jank is actually caused by this issue. Instrumenting to get the numbers. BUG=138903 Committed: https://crrev.com/42466460ec1a5c0f2953d13e57d0d290cb38ca21 Cr-Commit-Position: refs/heads/master@{#308702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M components/password_manager/core/browser/login_database.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vadimt
isherman@, please review
6 years ago (2014-12-16 23:09:18 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years ago (2014-12-16 23:11:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807263003/1
6 years ago (2014-12-16 23:12:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-17 00:21:32 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/42466460ec1a5c0f2953d13e57d0d290cb38ca21 Cr-Commit-Position: refs/heads/master@{#308702}
6 years ago (2014-12-17 00:22:16 UTC) #7
vadimt
5 years, 11 months ago (2015-01-26 21:54:47 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/878763002/ by vadimt@chromium.org.

The reason for reverting is: Undoing profiler instrumentations since the jank is
fixed..

Powered by Google App Engine
This is Rietveld 408576698