Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 807263002: replace COMPILE_ASSERT with static_assert in core/fetch/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
Mike West
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in core/fetch/ And simplify the checks while we're at it. BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/core/fetch/ResourceLoaderOptionsTest.cpp View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mostyn Bramley-Moore
@Mike: PTAL
6 years ago (2014-12-16 22:38:58 UTC) #2
Mike West
LGTM.
6 years ago (2014-12-17 08:43:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807263002/1
6 years ago (2014-12-17 08:46:09 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-17 10:26:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187357

Powered by Google App Engine
This is Rietveld 408576698