Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 807243003: Be more strict about attributes in sky-binder. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Be more strict about attributes in sky-binder. Instead of making all the built in attributes be global we match them to the elements they actually apply to. I also removed a bunch of attributes that no longer work in Sky (but haven't been removed from HTMLAttributeNames.in) yet, or which we plan to remove. I also removed the title property from HTMLElement. The <sky-box> widget forgot to declare its title attribute and no error was generated because of the title property existing on all elements. Sky doesn't have this so lets remove the API now and clean up the C++ later. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/38667f7d9ea2d61a61ab7e9fda837ed17f893c56

Patch Set 1 #

Patch Set 2 : fix sky-box #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -31 lines) Patch
M sky/engine/core/dom/Element.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/framework/sky-box/sky-box.sky View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/sky-element/element-registry.sky View 4 chunks +40 lines, -23 lines 0 comments Download
M sky/framework/sky-element/sky-binder.sky View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-16 06:42:45 UTC) #1
ojan
lgtm
5 years, 11 months ago (2015-01-16 20:32:54 UTC) #3
esprehn
5 years, 11 months ago (2015-01-16 22:41:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
38667f7d9ea2d61a61ab7e9fda837ed17f893c56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698