Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 807213002: Revert "Use the libc clone wrapper in sys_clone." (Closed)

Created:
6 years ago by oshima
Modified:
6 years ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Use the libc clone wrapper in sys_clone." This reverts commit d8a593bceaf0a4b38d06a8c13b948202d205f1b6. Reason for revert: see crbug.com/442817 > Previously, we directly invoked the syscall, which would not update > libc's PID cache in the child. Although the libc wrapper function > updates the PID cache, it unfortunately requires that the child run on a > different stack, even if CLONE_VM is not specified. We work around this > by briefly switching stacks in the child, then using longjmp to switch > back. This gives us a version of clone with fork-like behavior, which is > what we need for starting processes in new namespaces. > > BUG=312380 > Committed: https://crrev.com/d8a593bceaf0a4b38d06a8c13b948202d205f1b6 > Cr-Commit-Position: refs/heads/master@{#308510} BUG=312380, 442817 TBR=rickyz@chromium.org Committed: https://crrev.com/ddc896504d83fa943ede4732ed2c922c7e494154 Cr-Commit-Position: refs/heads/master@{#308636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -58 lines) Patch
M sandbox/linux/services/syscall_wrappers.h View 2 chunks +3 lines, -9 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.cc View 3 chunks +13 lines, -43 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
oshima
6 years ago (2014-12-16 18:34:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807213002/1
6 years ago (2014-12-16 18:35:27 UTC) #3
rickyz (no longer on Chrome)
lgtm
6 years ago (2014-12-16 18:37:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 19:34:30 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-16 19:35:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddc896504d83fa943ede4732ed2c922c7e494154
Cr-Commit-Position: refs/heads/master@{#308636}

Powered by Google App Engine
This is Rietveld 408576698