Chromium Code Reviews| Index: Makefile |
| diff --git a/Makefile b/Makefile |
| index 606b5d7bf176abc6984d32869d095265d340dacf..a8436a767d69b32359c2800d31aab65111870b0c 100644 |
| --- a/Makefile |
| +++ b/Makefile |
| @@ -27,8 +27,6 @@ |
| # Variable default definitions. Override them by exporting them in your shell. |
| -CXX ?= g++ |
| -LINK ?= g++ |
| OUTDIR ?= out |
| TESTJOBS ?= |
| GYPFLAGS ?= |
| @@ -144,13 +142,9 @@ endif |
| ifeq ($(deprecationwarnings), on) |
| GYPFLAGS += -Dv8_deprecation_warnings=1 |
| endif |
| -# asan=/path/to/clang++ |
| -ifneq ($(strip $(asan)),) |
| - GYPFLAGS += -Dasan=1 |
| - export CC=$(dir $(asan))clang |
| - export CXX=$(asan) |
| - export CXX_host=$(asan) |
| - export LINK=$(asan) |
| +# asan=on |
| +ifeq ($(asan), on) |
| + GYPFLAGS += -Dasan=1 -Dclang=1 |
| export ASAN_SYMBOLIZER_PATH=$(dir $(asan))llvm-symbolizer |
|
Jakob Kummerow
2015/01/07 13:02:05
This ain't gonna work no more. If you can't fix it
|
| TESTFLAGS += --asan |
| ifeq ($(lsan), on) |
| @@ -291,7 +285,6 @@ $(ARCHES): $(addprefix $$@.,$(DEFAULT_MODES)) |
| # Defines how to build a particular target (e.g. ia32.release). |
| $(BUILDS): $(OUTDIR)/Makefile.$$@ |
| @$(MAKE) -C "$(OUTDIR)" -f Makefile.$@ \ |
| - CXX="$(CXX)" LINK="$(LINK)" \ |
| BUILDTYPE=$(shell echo $(subst .,,$(suffix $@)) | \ |
| python -c "print \ |
| raw_input().replace('opt', '').capitalize()") \ |
| @@ -299,7 +292,7 @@ $(BUILDS): $(OUTDIR)/Makefile.$$@ |
| native: $(OUTDIR)/Makefile.native |
| @$(MAKE) -C "$(OUTDIR)" -f Makefile.native \ |
| - CXX="$(CXX)" LINK="$(LINK)" BUILDTYPE=Release \ |
| + BUILDTYPE=Release \ |
| builddir="$(shell pwd)/$(OUTDIR)/$@" |
| $(ANDROID_ARCHES): $(addprefix $$@.,$(MODES)) |
| @@ -468,8 +461,10 @@ $(ENVFILE): $(ENVFILE).new |
| # Stores current GYPFLAGS in a file. |
| $(ENVFILE).new: |
| - @mkdir -p $(OUTDIR); echo "GYPFLAGS=$(GYPFLAGS)" > $(ENVFILE).new; \ |
| - echo "CXX=$(CXX)" >> $(ENVFILE).new |
| + $(eval CXX_TARGET_ARCH:=$(shell $(CXX) -v 2>&1 | grep ^Target: | \ |
| + cut -f 2 -d " " | cut -f 1 -d "-" )) |
| + $(eval CXX_TARGET_ARCH:=$(subst aarch64,arm64,$(CXX_TARGET_ARCH))) |
| + @mkdir -p $(OUTDIR); echo "GYPFLAGS=$(GYPFLAGS) -Dtarget_arch=$(CXX_TARGET_ARCH)" > $(ENVFILE).new; |
| # Heap constants for grokdump. |
| DUMP_FILE = tools/v8heapconst.py |