Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 807143003: Remove the magic that sets CXX in the toplevel Makefile (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove the magic that sets CXX in the toplevel Makefile The logic was supposed to trigger a rebuild if the CXX variable is changed. However, it failed to track the other compiler related variables, and, what is worse, conflicted with the clang=1 gyp setting by forcing CXX to g++ The new logic just relies on tracking GYP defines, and checks whether the CXX binary - if set - has a target different from the host architecture. BUG=none R=jkummerow@chromium.org LOG=n Committed: https://crrev.com/fdf6777072db5927b4e05bd93485b6a5d1951027 Cr-Commit-Position: refs/heads/master@{#25973}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M Makefile View 1 5 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-22 15:45:49 UTC) #1
Jakob Kummerow
LGTM with comment. https://codereview.chromium.org/807143003/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/807143003/diff/1/Makefile#newcode148 Makefile:148: export ASAN_SYMBOLIZER_PATH=$(dir $(asan))llvm-symbolizer This ain't gonna ...
5 years, 11 months ago (2015-01-07 13:02:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807143003/20001
5 years, 11 months ago (2015-01-07 13:06:27 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 13:33:14 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 13:33:28 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fdf6777072db5927b4e05bd93485b6a5d1951027
Cr-Commit-Position: refs/heads/master@{#25973}

Powered by Google App Engine
This is Rietveld 408576698