Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 807093003: chromeos: Add pref for automated brightness increases. (Closed)

Created:
5 years, 11 months ago by Daniel Erat
Modified:
5 years, 11 months ago
Reviewers:
bartfab (slow), bruthig
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Add pref for automated brightness increases. Add a pref that controls whether the Chrome OS power manager will ensure that the screen brightness is nonzero when it observes user activity. Also bump the system_api dependency to 7678688b. BUG=chromium:256914 Committed: https://crrev.com/8f279a0d45ab24506dce54f14a644eeb40f51874 Cr-Commit-Position: refs/heads/master@{#310786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/power_prefs.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/power/power_prefs_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/dbus/power_policy_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/power_policy_controller.cc View 3 chunks +8 lines, -1 line 0 comments Download
M chromeos/dbus/power_policy_controller_unittest.cc View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Daniel Erat
5 years, 11 months ago (2015-01-08 20:41:31 UTC) #2
bruthig
On 2015/01/08 20:41:31, Daniel Erat wrote: lgtm
5 years, 11 months ago (2015-01-08 20:47:49 UTC) #3
bartfab (slow)
lgtm
5 years, 11 months ago (2015-01-09 14:57:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/807093003/1
5 years, 11 months ago (2015-01-09 15:16:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 17:12:03 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 17:12:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f279a0d45ab24506dce54f14a644eeb40f51874
Cr-Commit-Position: refs/heads/master@{#310786}

Powered by Google App Engine
This is Rietveld 408576698