Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 807013004: Merge 187509 "Layout captions in simplifiedNormalFlowLayout for ..." (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by dsinclair
Modified:
2 years, 9 months ago
Reviewers:
dsinclair
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Project:
blink
Visibility:
Public.

Description

Merge 187509 "Layout captions in simplifiedNormalFlowLayout for ..." > Layout captions in simplifiedNormalFlowLayout for tables. > > It is currently possible to get into simplifiedNormalFlowLayout for a table > while the captions need layout. Currently the simplified code will just > iterate over all of the table sections and lay them out if needed. > > This CL adds iteration over the table captions as well and makes sure they're > also laid out during simplifedNormalFlowLayout. > > BUG=414109 > > Review URL: https://codereview.chromium.org/804383002 TBR=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --4 lines) Patch
A + LayoutTests/fast/table/caption-position.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/caption-position-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/display-table-caption-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/display-table-caption-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 2 (0 generated)
dsinclair
2 years, 9 months ago (2015-01-05 15:29:52 UTC) #1
dsinclair
2 years, 9 months ago (2015-01-05 15:30:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r187860.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa