Templatize visitor arguments for TraceTrait mark and trace methods.

Templatize visitor arguments for TraceTrait mark and trace methods.

This CL replaces Visitor* in TraceTrait<T>::{mark,trace} methods arguments
to template parameter VisitorDispatcher.

This is to prepare for InlinedGlobalMarkingVisitor implementaion, so that
those methods can also be used to dispatch
TraceTrait<T>::mark(InlinedGlobalMarkingVisitor) in addition to the current
TraceTrait<T>::mark(Visitor*) usage.

BUG=420515
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187674

[kouhei (in TOK), 2014-12-17 03:20:42]

kouhei@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org

[kouhei (in TOK), 2014-12-17 03:20:43]

PTAL. This is split from https://codereview.chromium.org/803443002/

[haraken, 2014-12-17 03:43:14]

LGTM

[kouhei (in TOK), 2014-12-17 04:37:42]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2014-12-17 04:37:49]

The CQ bit was unchecked by kouhei@chromium.org

[kouhei (in TOK), 2014-12-17 04:38:35]

kouhei@chromium.org changed reviewers:
+ erik.corry@gmail.com

[kouhei (in TOK), 2014-12-17 04:38:36]

erik.corry: Would you take a look?

[kouhei (in TOK), 2014-12-19 09:53:37]

kouhei@chromium.org changed reviewers:
+ jochen@chromium.org

[kouhei (in TOK), 2014-12-19 09:53:38]

jochen: Would you take a look at wtf/ changes?

[jochen (gone - plz use gerrit), 2014-12-22 14:20:21]

jochen@chromium.org changed reviewers:
+ haraken@chromium.org

[jochen (gone - plz use gerrit), 2014-12-22 14:20:22]

lgtm

[kouhei (in TOK), 2014-12-24 06:26:13]

Thanks!

[kouhei (in TOK), 2014-12-24 06:26:17]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-12-24 06:26:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/807003004/100001

[commit-bot: I haz the power, 2014-12-24 07:52:39]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187674

[sof, 2014-12-24 15:11:57]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2014-12-24 15:11:57]

Breaks MSVC compilation, 


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20...

(had a go fixing it in https://codereview.chromium.org/799453003/ , but
__if_exists(T::trace) handling over "const char*" is unexpected.)

[kouhei (in TOK), 2014-12-25 01:36:27]

On 2014/12/24 15:11:57, sof wrote:
> Breaks MSVC compilation, 
> 
> 
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20...
> 
> (had a go fixing it in https://codereview.chromium.org/799453003/ , but
> __if_exists(T::trace) handling over "const char*" is unexpected.)

Thanks for noticing.
Let me revert this for now.

[kouhei (in TOK), 2014-12-25 01:39:10]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/828453003/ by kouhei@chromium.org.

The reason for reverting is: Breaks msvc:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20....

[sof, 2014-12-25 13:43:39]

On 2014/12/25 01:36:27, kouhei wrote:
> On 2014/12/24 15:11:57, sof wrote:
> > Breaks MSVC compilation, 
> > 
> > 
> >
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20...
> > 
> > (had a go fixing it in https://codereview.chromium.org/799453003/ , but
> > __if_exists(T::trace) handling over "const char*" is unexpected.)
> 
> Thanks for noticing.
> Let me revert this for now.

Thanks for doing that; I'm not convinced there is a workable solution for
<=VS2013 if this wants to match against a non-public trace() method.