Index: tools/run-bisect-perf-regression.py |
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py |
index f2eff2a9d65de9896f07f3f6fdbbd0986862630b..ac6f14e39490e420fe07ddd71ce26443590604b6 100755 |
--- a/tools/run-bisect-perf-regression.py |
+++ b/tools/run-bisect-perf-regression.py |
@@ -148,13 +148,7 @@ def _ValidatePerfConfigFile(config_contents): |
Returns: |
True if valid. |
""" |
- required_parameters = [ |
- 'command', |
- 'repeat_count', |
- 'truncate_percent', |
- 'max_time_minutes', |
- ] |
- return _ValidateConfigFile(config_contents, required_parameters) |
+ return _ValidateConfigFile(config_contents, required_parameters=['command']) |
def _ValidateBisectConfigFile(config_contents): |
@@ -169,16 +163,9 @@ def _ValidateBisectConfigFile(config_contents): |
Returns: |
True if valid. |
""" |
- required_params = [ |
- 'command', |
- 'good_revision', |
- 'bad_revision', |
- 'metric', |
- 'repeat_count', |
- 'truncate_percent', |
- 'max_time_minutes', |
- ] |
- return _ValidateConfigFile(config_contents, required_params) |
+ return _ValidateConfigFile( |
+ config_contents, |
+ required_parameters=['command', 'good_revision', 'bad_revision']) |
def _OutputFailedResults(text_to_print): |
@@ -498,13 +485,13 @@ def _RunBisectionScript( |
'--command', config['command'], |
'--good_revision', config['good_revision'], |
'--bad_revision', config['bad_revision'], |
- '--metric', config['metric'], |
'--working_directory', working_directory, |
'--output_buildbot_annotations' |
] |
# Add flags for any optional config parameters if given in the config. |
options = [ |
+ ('metric', '--metric'), |
('repeat_count', '--repeat_test_count'), |
('truncate_percent', '--truncate_percent'), |
('max_time_minutes', '--max_time_minutes'), |