Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Issue 806943007: Use builder_type when requesting/fetching builds, and add support for full linux builds. (Closed)

Created:
5 years, 11 months ago by qyearsley
Modified:
5 years, 10 months ago
Reviewers:
prasadv
CC:
chromium-reviews, RobertoCN
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use builder_type when requesting/fetching builds, and add support for full linux builds. Changes in this CL: - In request_build.py, add a URL for linux try bot. - Add sample config for functional bisect. - Make perf-related config parameters optional. - Use builder type when starting build try jobs, and when fetching builds. A few other changes: - Update bisect_perf_regression.py file docstring. - Rename _BuilderTryjob to _StartBuilderTryJob and refactor. - Remove unused code in request_build.py. Proposed follow-up: - Move functions related to builder to be methods of one class, so that the builder-specific info/logic (e.g. builder bot and archive location) is in one place. BUG= Committed: https://crrev.com/bd0f02085daa509d9d56a9c313976e814759eb82 Cr-Commit-Position: refs/heads/master@{#313415}

Patch Set 1 #

Patch Set 2 : Make config parameters "metric", "repeat_count", "truncate_percent", "max_time_minutes" all optiona… #

Patch Set 3 : Use tryserver.chromium.linux try bot for full builds. #

Patch Set 4 : Pass builder_type into fetch_build.GetBucketAndRemotePath #

Patch Set 5 : Remove temporary print statements. #

Patch Set 6 : Rebased #

Total comments: 3

Patch Set 7 : Fixes in response to code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -252 lines) Patch
M tools/auto_bisect/bisect_perf_regression.py View 1 2 3 4 5 6 9 chunks +125 lines, -86 lines 0 comments Download
M tools/auto_bisect/bisect_perf_regression_test.py View 1 2 3 4 5 4 chunks +17 lines, -14 lines 0 comments Download
A tools/auto_bisect/configs/linux.bisect.functional.cfg View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M tools/auto_bisect/fetch_build.py View 1 2 3 4 5 6 3 chunks +5 lines, -2 lines 0 comments Download
M tools/auto_bisect/request_build.py View 1 2 3 4 5 6 6 chunks +11 lines, -132 lines 0 comments Download
M tools/run-bisect-perf-regression.py View 1 3 chunks +5 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
qyearsley
5 years, 11 months ago (2015-01-16 19:18:10 UTC) #2
qyearsley
Hi Prasad and Roberto, this CL is intended to set things up to start using ...
5 years, 11 months ago (2015-01-20 05:26:13 UTC) #3
prasadv
https://codereview.chromium.org/806943007/diff/100001/tools/auto_bisect/bisect_perf_regression.py File tools/auto_bisect/bisect_perf_regression.py (right): https://codereview.chromium.org/806943007/diff/100001/tools/auto_bisect/bisect_perf_regression.py#newcode682 tools/auto_bisect/bisect_perf_regression.py:682: """Returns an SVN repo to use for try jbos ...
5 years, 10 months ago (2015-01-27 22:54:32 UTC) #4
prasadv
lgtm
5 years, 10 months ago (2015-01-27 22:54:38 UTC) #5
qyearsley
Thanks for the review :-)
5 years, 10 months ago (2015-01-27 23:35:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806943007/120001
5 years, 10 months ago (2015-01-27 23:36:47 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 10 months ago (2015-01-28 00:27:34 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 00:28:54 UTC) #10
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/bd0f02085daa509d9d56a9c313976e814759eb82
Cr-Commit-Position: refs/heads/master@{#313415}

Powered by Google App Engine
This is Rietveld 408576698