Issue 806873003: tools/gn: Make it 'gn check' clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 806873003: tools/gn: Make it 'gn check' clean. (Closed)

Created:
6 years ago by tfarina

Modified:
6 years ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina, Dirk Pranke, scottmg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

tools/gn: Make it 'gn check' clean. This was checked with the following command line: $ out/Debug/gn check out_gn/Debug //tools/gn/* And cleaned until it reported "Header dependency check OK". BUG=367595, 376000 TEST=see above TBR=brettw@chromium.org Committed: https://crrev.com/b8e602bfd91331d0d7976ce6e45f846c6d1a8433 Cr-Commit-Position: refs/heads/master@{#309371}