Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 806853007: Files.app: Fix exception thrown by ContentProvider if getLatest is called with the type 'media|thum… (Closed)

Created:
5 years, 11 months ago by hirono
Modified:
5 years, 11 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Fix exception thrown by ContentProvider if getLatest is called with the type 'media|thumbnail'. Previously there is assumption in ContentProvider#fetch that only one request is called for one URL at the same time, and the next request is never called before the previous request completes. But actually multiple requests can be called for each meatadata type. ContentProvider handles 'media' and 'thumbnail' metadata type, so if both metadata type is specified, it causes an exception in ContentProvider. BUG=446396 TEST=FileManagerJsTest.MetadataCache Committed: https://crrev.com/a2fac13bb5fcc690f8d8e8d81a680c1b85b523c0 Cr-Commit-Position: refs/heads/master@{#310061}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -16 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js View 1 4 chunks +23 lines, -9 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_unittest.html View 1 chunk +1 line, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_unittest.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL the CL? Thanks!
5 years, 11 months ago (2015-01-06 05:44:05 UTC) #2
yawano
lgtm with very small nit. Thank you! https://codereview.chromium.org/806853007/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js (right): https://codereview.chromium.org/806853007/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js#newcode956 ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js:956: * @type ...
5 years, 11 months ago (2015-01-06 06:04:52 UTC) #3
hirono
Thanks! https://codereview.chromium.org/806853007/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js (right): https://codereview.chromium.org/806853007/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js#newcode956 ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js:956: * @type {!Object<!string, !Array<!Function>>} On 2015/01/06 06:04:52, yawano ...
5 years, 11 months ago (2015-01-06 06:16:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806853007/20001
5 years, 11 months ago (2015-01-06 06:17:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 06:59:12 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 07:00:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2fac13bb5fcc690f8d8e8d81a680c1b85b523c0
Cr-Commit-Position: refs/heads/master@{#310061}

Powered by Google App Engine
This is Rietveld 408576698