Issue 806843004: Allow build under GTK+ 2.24.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 806843004: Allow build under GTK+ 2.24. (Closed)

Created:
6 years ago by polpo

Modified:
6 years ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow build under GTK+ 2.24. Some parts of libgtk2ui use newer function and #define names than what's in GTK+ 2.24, which is what ships with RHEL/CentOS 6.6. This commit allows Chromium to work on RHEL/CentOS 6.6 by checking for the appropriate GTK version and using the appropriate API. BUG=443005 R=erg@chromium.org

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -0 lines)			Patch
M	AUTHORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806843004/1

6 years ago (2014-12-17 20:11:36 UTC) #6

commit-bot: I haz the power

6 years ago (2014-12-17 20:19:14 UTC) #8

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages