build/android/tombstones.py - Issue 806843002: Reland of Migrate DeviceUtils.ReadFile to adb_wrapper (try 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/tombstones.py

Issue 806843002: Reland of Migrate DeviceUtils.ReadFile to adb_wrapper (try 3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enable command line test only for android Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/perf/thermal_throttle.py ('k') | tools/telemetry/telemetry/core/backends/android_command_line_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/tombstones.py

diff --git a/build/android/tombstones.py b/build/android/tombstones.py

index a78d89fa562ba86a2a7638cb921a3faff01e4c47..7449a73b9aab7baf216dc22dfb98a0aa4fa21a74 100755

--- a/build/android/tombstones.py

+++ b/build/android/tombstones.py

@@ -63,7 +63,8 @@ def _GetTombstoneData(device, tombstone_file):

Returns:

A list of lines

"""

- return device.ReadFile('/data/tombstones/' + tombstone_file, as_root=True)

+ return device.ReadFile(

+ '/data/tombstones/' + tombstone_file, as_root=True).splitlines()

def _EraseTombstone(device, tombstone_file):